search

IBM / vscode-ibmi-projectexplorer

IBM i Project Explorer for VS Code
https://ibm.github.io/vscode-ibmi-projectexplorer/
Apache License 2.0
22 stars 7 forks source link

Suggestion for more explicit confirmation of library delete #609

Closed ThePrez closed 2 weeks ago

ThePrez commented 2 weeks ago

The confirmation dialog when deleting a library is phrased like so:

Are you sure you want to delete QSYS/RASCAL *LIB?

As a first-time user of this extension, and given that I was taking an action from the "library list" view, I thought it was just deleting the library from the library list, not actually deleting the library from disk (I missed the context clues from the adjacent options like "clear library" and "copy"). Thankfully I was supervised by a helpful @edmundreinhardt

I may be the "odd one out" in thinking that the delete action actually deleted the library, so feel free to close this without changes if yous see fit.

One proposal, however, would be to make the warning/confirmation more explicit, for instance:

This option will delete library RASCAL (and all of its contents) from the IBM i system. Are you sure you want to do this?
mipjones commented 2 weeks ago

You are definitely not the "odd one out", I concur your sentiment. Great confirmation message proposal. It would be even safer if we add: This action cannot be undone.