Deploy fails due to long host name

IBM / watson-banking-chatbot

A chatbot for banking that uses the Watson Assistant, Discovery, Natural Language Understanding and Tone Analyzer services.

https://developer.ibm.com/patterns/create-cognitive-banking-chatbot/

Apache License 2.0

264 stars 374 forks source link

Deploy fails due to long host name #42

Closed RiyaMRoy04 closed 7 years ago

RiyaMRoy04 commented 7 years ago

Deploy is failing due to long hostname. Can random route be set to false for successful deployment at first attempt?

stevemar commented 7 years ago

We've done that before in some apps, like https://github.com/IBM/watson-discovery-news/blob/master/manifest.yml#L13 so yah, go ahead and submit a PR if you'd like

sauravraiguru commented 7 years ago

If we make it false, the 1st deployment will work, but post that all deployments you need to put in your own app-name to make it unique.

I suppose we should keep it as it is, it fails only sometimes when there is an exact conflict in datetime() while deploying, else the developer can always change the route name before 'deploy' in toolchain.

RiyaMRoy04 commented 7 years ago

@sauravraiguru Thanks for the suggestion. But have been facing this issue due to "long hostname with random words" while random route is enabled(as shown in screenshot below). There is a character limit for hostname due to which deployment fails at first attempt most of the times! When random route is set to false it just picks up timestamp and host name will be much shorter and still unique!

And you can't change "route name" before 'deploy' in toolchain when the random route is enabled.You can only change APP NAME. It still picks up the random route(shown in the screenshot below). Telling a developer to change the "APP NAME" is a workaround but again a manual process! Hence, had suggested it! screen shot 2017-10-06 at 7 09 58 pm

Thanks @stevemart I think we should set it to false since sometimes it is just failing to deploy in the first attempt itself.

markstur commented 7 years ago

yes, please set it to false. The timestamp should be unique enough. The random route was only needed when the host name was specified in the manifest. It looks like that part was already fixed.

sauravraiguru commented 7 years ago

@RiyaMRoy04 Thanks for the information! I did try it a few times & it did not fail, but anyway timestamp is best way to keep the APP_NAME unique. As suggested you can send in a PR.

P.S If this is a known issue that APP_NAME is having a char_limit & this is exceeded by random-route, we should let the CF team know about this.

RiyaMRoy04 commented 7 years ago

@sauravraiguru I was talking about HOST NAME or ROUTE NAME and not APP NAME. Thanks, shall send PR.. It failed in many instances when we had done workshop and had to re-deploy multiple times. Hence!