search

IBM / watson-nao-robot

Use a robot to answer queries on financial data by integrating with the IBM Watson Assistant service and IBM Watson Studio
https://developer.ibm.com/patterns/robotic-calculations-and-inference-agent
Apache License 2.0
38 stars 63 forks source link

Remove credentials for Watson Speech to Text #6

Closed arlemi closed 6 years ago

RK-Sharath commented 6 years ago

@stevemart I have removed the credentials and submitted a PR for the same. Please review and merge.

arlemi commented 6 years ago

@RK-Sharath Your PR still has an API Key in it.

RK-Sharath commented 6 years ago

@arlemi Please advise where is it as i have removed the credentials.

arlemi commented 6 years ago

@RK-Sharath Line 338 there's a Google API key for their speech-to-text service. You could have checked that by looking at my PR. Also you shouldn't merge your own pull requests without having someone else reviewing them.

RK-Sharath commented 6 years ago

@arlemi Thank you. I have submitted another PR for review.

stevemar commented 6 years ago

@arlemi thanks for the PR. I'll clean up the conflict and merge this one as it removes the google API key and the service uname/pass