spawn call overwrites instead of ORs flags

IBM / xmlservice

XML-based interface for accessing IBM i resources

https://xmlservice.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

35 stars 18 forks source link

spawn call overwrites instead of ORs flags #58

Open NattyNarwhal opened 2 years ago

NattyNarwhal commented 2 years ago

See: https://github.com/IBM/xmlservice/blob/20800d6be4aa4748b6eb226896c899c9c7e752ab/src/plugipc.rpgle#L1488

It overwrites a mutually exclusive job name flag, but it's also getting rid of the multithreaded job flag. Is this intentional? If so, the previous two lines should be dropped or this turned into an |=?

jimoibm commented 2 years ago

It seems intentional. The change comment said:

1.9.3 xmlservice change spawn attributes no thread, different name

Previous flags are overwritten. Not sure why leave dead code there. Since XmlService is running under single-threaded job, the setup seems OK.