search

IBM / xmlservice

XML-based interface for accessing IBM i resources
https://xmlservice.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
35 stars 18 forks source link

Qp0sDisableSignals ??? #60

Closed AndreaRibuoli closed 1 year ago

AndreaRibuoli commented 2 years ago

What's the point of mapping Qp0sDisableSignals to Qp0sEnableSignals ?

      *++++++++++++++++++++++++++++++++++++++++++++++++++++++++
      * Qp0sDisableSignals(): Disable signals
      *++++++++++++++++++++++++++++++++++++++++++++++++++++++++
     D Qp0sDisableSignals...
     D                 PR            10I 0 extproc('Qp0sEnableSignals')
jimoibm commented 2 years ago

It might be a copy/paste error to Qp0sDisableSignals. The export procedure is not used in components of XmlService internally. Should not cause any error yet. What is you usage of that?

AndreaRibuoli commented 2 years ago

I was looking at the source code to understand the positioning of XmlService. The number of internally-unused extproc in PLUGSIG_H.RPGLE is high so I was wondering if these exports where there on behalf of specific programming language toolkits' adoption and -if that is the case- how they were actually used. The extprocs in PLUGCONF_H.RPGLE and PLUGPASE.RPGLE seem much more XmlService internal-use driven.

jimoibm commented 2 years ago

Indeed there are export procedures not used internally. Not sure why they were added.

alanseiden commented 1 year ago

Created PR https://github.com/IBM/xmlservice/pull/61

alanseiden commented 1 year ago

PR has been merged.