COBOL - Toggle line comment not working for non-blank lines

ian-burnett commented 3 years ago

Development environment used

Z Open Editor version: 1.2.6
Editor Platform
- [X] Visual Studio Code
- [ ] Red Hat CodeReady Workspaces
- [ ] Eclipse Che
- [ ] Standalone Theia
Editor Platform Version: 1.60.0
Operating System: Windows 10 Enterprise 21H1
Java Version: Java(TM) SE Runtime Environment (build 8.0.6.7 - pwa6480sr6fp7-20200312_01(SR6 FP7))
[ ] Related to RSE API?
- RSE API Plugin version:
- Zowe CLI version:
- Node.js version:
Logs attached: no

Problem Description

Detailed steps for reproducing the problem:

Create a basic COBOL file and open for editing
Position the cursor on the line beginning "01"
Use either the command "Toggle line comment" or keyboard shortcut Ctrl + / to toggle the line comment

Sample basic program:

       identification division.
       program-id.    mytest.

       data division.
       working-storage section.

      *    Return code
       01  rc pic s9(9) binary.

Observed behavior

Line is incorrectly indented and not marked as a comment (asterisk starts in column 13):

            *  01  rc pic s9(9) binary.

Executing the "toggle" again makes things worse:

                  * *  01  rc pic s9(9) binary.

Expected behavior

Asterisk or slash should be toggled in column 7
Indentation of code should remain unchanged

See also Comment lines in the COBOL documentation.

davidkcoblentz commented 3 years ago

COBOL - Code coloring on commented lines I am not sure but I think I should put this comment here also since it pertains to COBOL Comments. I noticed when a COBOL line is commented the whole line changes to the comment color including positions 1-6. But In the IBM TSO editor the coloring doesn't change positions 1-6 even if the line is commented. It only colors the rest of the line up to 72 with the comment color. The same is true for columns 73-80 which maintain a color other than the comment color. See an example the image below.

TSO Editor Color Example Positions 1-72 to show 73-80 of the same lines above

as compared to IBM Z Open Editor

I am using VS Code: Version: 1.61.1 (user setup) Commit: c13f1abb110fc756f9b3a6f16670df9cd9d4cf63 Date: 2021-10-14T01:19:42.089Z Electron: 13.5.1 Chrome: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.17763

IBM Z Open Editor extension: V1.2.7

phaumer commented 2 years ago

Added that in v1.4.1

ian-burnett commented 2 years ago

Works for me thanks!

davidkcoblentz commented 2 years ago

Yes, works great even if the selected lines have some comments already. Great Work!!

Thank you, @.***

From: Peter Haumer @.> Sent: Thursday, November 18, 2021 4:17 PM To: IBM/zopeneditor-about @.> Cc: Coblentz, David @.>; Comment @.> Subject: Re: [IBM/zopeneditor-about] COBOL - Toggle line comment not working for non-blank lines (#157)

Added that in v1.4.1

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/IBM/zopeneditor-about/issues/157*issuecomment-973402551__;Iw!!OgnrLJOUc50AAzM!cx-BZFXyllKFXKJEs-8AvS0Prbc8PHUMldc0GsM8XT9rrY3Y0C57qeuVIF2rOJ_CKQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATC2YG5VW75VPVBTFEK5MZDUMWCNVANCNFSM5DVVNNRA__;!!OgnrLJOUc50AAzM!cx-BZFXyllKFXKJEs-8AvS0Prbc8PHUMldc0GsM8XT9rrY3Y0C57qeuVIF1m3DTI1w$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!OgnrLJOUc50AAzM!cx-BZFXyllKFXKJEs-8AvS0Prbc8PHUMldc0GsM8XT9rrY3Y0C57qeuVIF1VEgfJhw$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!OgnrLJOUc50AAzM!cx-BZFXyllKFXKJEs-8AvS0Prbc8PHUMldc0GsM8XT9rrY3Y0C57qeuVIF1SPRO_YA$.

IBM / zopeneditor-about