IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
47 stars 25 forks source link

COBOL - Error while processing boolean compilation variables #321

Closed FALLAI-Denis closed 1 year ago

FALLAI-Denis commented 1 year ago

Development environment used

Problem Description

The COBOL Language Server does not correctly handle condition expressions on compilation variables in boolean format compared with the constant b'0' or b'1', which subsequently triggers parse errors at the global level and emitting false syntax errors.

image

Problems also on parsing the >>evaluate directive:

image

image

FALLAI-Denis commented 1 year ago

Hi,

I haven't tested it but I think that if the management of conditional compilation does not work at the Language Server level, and this leads to poor or false detection of the COPYBOOKs actually used by the program during compilation, this must have a impact on the IBM User Build function (call to DBB-zAppbuild): copybooks will be missing (transfer from local to remote system) when compiling User Build.

In general, the poor management of conditional compilation by the COBOL Language Server causes us many problems and makes most of the features specific to Z Open Editor unusable (any syntax error disables many features in ZOE).

Perhaps you should consider no longer managing conditional compilations and considering that all the source lines are part of the program (management by excess, but at least the "necessary" is managed, in the absence of the "sufficient"), or provide an option to allow disabling conditional compilation support in the COBOL Language Server.

In any case, we want substantive and rapid action on the problems related to the management of conditional compilation in the COBOL Language Server because we have now switched to intensive use mode of Z Open Editor and these problems are becoming critical for us.

FALLAI-Denis commented 1 year ago

See https://github.com/IBM/zopeneditor-about/issues/154, https://github.com/IBM/zopeneditor-about/issues/203, https://github.com/IBM/zopeneditor-about/issues/199, https://github.com/IBM/zopeneditor-about/issues/113, https://github.com/IBM/zopeneditor-about/issues/96, https://github.com/IBM/zopeneditor-about/issues/88, https://github.com/IBM/zopeneditor-about/issues/83

phaumer commented 1 year ago

Fixed in Z Open Editor 3.1.0