search

IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
49 stars 20 forks source link

IF END-IF without no instruction is OK for zOpenEditor #341

Open ROBIN-Olivier opened 1 year ago

ROBIN-Olivier commented 1 year ago

When I code a condition with IF ... END-IF without statement, compilation is KO, but parsing of zOpenEditor is OK: image

phaumer commented 1 year ago

Changed it to an enhancement as our editor will not catch everything that the compiler rejects.

FALLAI-Denis commented 1 year ago

Hi,

As I already said, The language server is not a language compiler 😊

phaumer commented 1 year ago

I agree with that. Our goal is to, of course, not show any false errors for programs that compile, but we cannot show all errors the compiler would find. However, we can only add value if we can make that set of errors we do show in the editor as large as we can. Hence, this would be a valuable enhancement.

ROBIN-Olivier commented 1 year ago

The developers I train are delighted that this parsing shows them syntax errors, so they avoid a lot of compilation errors when writing their instructions.

I understand that the parser cannot catch all compilation errors as it depends on the compiler. But are there compilers that accept an empty IF END-IF (#341) or a COPY in column 7 (#340)?