IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
49 stars 20 forks source link

z Open Editor is showing red lines under copybooks even though they are there #363

Closed oakmount66 closed 7 months ago

oakmount66 commented 11 months ago

Sometimes when we open a COBOL program not all copybooks are marked as found, but still have this red line below. When looking in the log for z Open Editor and local on the PC the copybook is there. See sample in picture below. COBOL copybook error

Se also runtime environment versions in below: COBOL copybook error - versions

phaumer commented 10 months ago

@oakmount66 I am not able to reproduce this issue. I was testing with 1000 copybooks via z/OSMF on Windows, which is what we now do for our acceptance tests before we ship as well.

  1. In the log output of you screenshot you see the path to the temp directory in which the files get downloaded. If you open such as file directly from the file system in that location: Does it have the right contents? Is the encoding correct?
  2. If it does have the right content: do the red squiggles go away as soon as you start editing the program (i.e. then we reparse the program and perhaps the file will then be read correctly). That could be an indication that the parser had some issues. In that case it would be good to get the full Debug log as well as the language server log for further investigation.
oakmount66 commented 10 months ago

Hi Peter. Regarding #1 yes it's there, it's the right content and the right encoding. I haven't had the opportunity to test #2 but will get back as soon as possible.

oakmount66 commented 10 months ago

Hi Peter. Now I have the logs etc. I'm not keen on putting them into the site here cause some of the files includes proprietary code. Can I in anyway send them to you personally?

phaumer commented 10 months ago

@oakmount66 sure, my address is my git account name at us.ibm.com.

antonkc commented 8 months ago

Greetings @phaumer,

I have a look-alike problem. I will describe it here for you to judge if I should open a new issue or reporting here is good enough.

After some testing I managed to reliably reproduce through these steps:

  1. Open Cobol file with copybooks
  2. Open the same cobol file with another name
  3. Compare both files ("File: Compare active file with..." command)
  4. Close both files, but keep the comparison
  5. Close VSCode
  6. Open VSCode (Comparison should be restored without opening the files)
  7. Review copybook errors. Often, one side reports the lack of copybooks despite them being donwloaded.

Additional observations:

Additional info: zowe version - 7.9.1 VSCode version IBM Z Open Editor Version 3.3.3 ZOWE explorer version 2.13.1

Best regards.

sdaimwood commented 8 months ago

Greetings @phaumer,

I have a look-alike problem. I will describe it here for you to judge if I should open a new issue or reporting here is good enough.

After some testing I managed to reliably reproduce through these steps:

...

Thank you @antonkc for the detailed steps, I was able to reproduce this inconsistent behavior as well. We will investigate and determine a fix. As you noted, editing the document should result in the links correctly showing and the errors disappearing, but this should be handled correctly from the start.

phaumer commented 7 months ago

Fixed in v3.4.0.