IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
47 stars 25 forks source link

Tabstops and Tabsize of the settings.json are no longer activ #365

Closed SG-A47 closed 7 months ago

SG-A47 commented 7 months ago

VSCode 1.79.2 Z Open Editor 3.3.1 on Windows 11

The definitions for zopeneditor.cobol.tabstops and Tabsize of the settings.json don´t work any more after the last Update. Tabsize now is 6 and there are no Tabstops.

There is no information that something might have changed along with the Updates of VSCode or Z Open Editor. How can I get back my Tabstops and the Tabsize?

phaumer commented 7 months ago

@SG-A47 could you provide more details and the settings you are using? I do not see a change. When I define custom tab stops such as

"zopeneditor.cobol.tabstops": [
    0,
    10,
    12,
    15
  ]

I can tab forward and backward as specified.

SG-A47 commented 7 months ago

Here are my tabstops for cobol. "zopeneditor.cobol.tabstops": [ 0, 6, 7, 11, 14, 17, 20, 23, 26, 29, 32, 35, 38, 41, 44, 71 ], These tabstops are now no longer working. Tabbing stops at 6, 11, 16 and so on. So tabsize is 5. But grafik and User setting, workspace setting and Directory setting are the same. They are all 3.

SG-A47 commented 7 months ago

Could it have something to do with the change to the ZAPP files? If so, where do I have to copy the tab options in the zapp files?

SG-A47 commented 7 months ago

I must state that there is no language specific indentation any more. The Editor is working with some fixed tab sizes. For Cobol it ist 5. grafik For HLASM it is 6 grafik The values for zopeneditor.cobol.tabstops are not active. It seems that these options from the settings.json are not read.

benjamin-t-santos commented 7 months ago

@SG-A47 Can you try and follow the steps outlined here and send a screenshot of the output after you press 'tab' in a Cobol file? https://code.visualstudio.com/docs/getstarted/keybindings#_troubleshooting-keybindings That will help us tell if the tab is being recognized/handled correctly by our extension.

Other things to check:

FALLAI-Denis commented 7 months ago

Hi,

It seems to me that the information Spaces (I do'nt have Tab Size?) returned in the VS Code status bar reflects the choices to replace tabs by spaces for indentations. Tab Size is also auto-detected by file analysis. Tab Size is not Tab Stop. See Basic Editing in Visual Studio Code - Indentation in VS Code documentation.

Stopping on specific columns using the tab key seems to me to be a specific Z Open Editor feature, managed by the zopeneditor.cobol.tabstops setting.

@SG-A47: perhaps there is an error in your settings.json file (user or workspace), which prevents recognition of the zopeneditor.cobol.tabstops setting? What happens if you temporarily disable your settings.json files by renaming them (and reload Window), which will cause them to revert to the default values?

In this screen capture, tab key is used before typing "x".

TabStop

SG-A47 commented 7 months ago

Heureka! Problem fixed. The reason was another settings.json may be old one that was used before mine. It must have been in front of my setting.json in the search path. Thnx2all

phaumer commented 7 months ago

Excellent news. Thanks for the update.