PL/1 false positive syntax errors and highlighting issues

[tombav]

Development environment used

• Z Open Editor version:
• Editor Platform
  • [x] Visual Studio Code
  • [ ] Red Hat CodeReady Workspaces
  • [ ] Eclipse Che
  • [ ] Standalone Theia
• Editor Platform Version:

  Version: 1.87.1 (system setup)
  Commit: 1e790d77f81672c49be070e04474901747115651
  Date: 2024-03-06T00:21:36.258Z
  Electron: 27.3.2
  ElectronBuildId: 26836302
  Chromium: 118.0.5993.159
  Node.js: 18.17.1
  V8: 11.8.172.18-electron.0

• Operating System (on which VS Code runs such as Windows 10 2004, otherwise name and version of platform such as OpenShift v4.3):

  OS: Windows_NT x64 10.0.19045

• Java Version (when using VS Code or Theia, execute java -version and paste the details here):

  openjdk 17.0.10 2024-01-16
  OpenJDK Runtime Environment (build 17.0.10+7-Ubuntu-122.04.1)
  OpenJDK 64-Bit Server VM (build 17.0.10+7-Ubuntu-122.04.1, mixed mode, sharing)

• [ ] Related to RSE API?
  • RSE API Plugin version:
  • Zowe CLI version:
  • Node.js version:
• Logs attached (see here how to get them): yes/no

Problem Description

1. A size of the HANDLER is valid but is marked as an error

2. FILE VARIABLE is valid syntax

3. Some keywords followed by comma are not highlighted as keywords

4. Other valid syntax marked as error.

   The CALLER_AMODE variable is passed using INCAFTER compile option where the included file contains one line:

[Russell-May]

Hi @tombav , I'm trying to replicate these syntax errors and highlighting issues, can you provide an example pli file with these issues in them as the context of the source can play a role in what may be parsing incorrectly. Thanks.

[tombav]

Copy & paste the following examples. Each example to its own new file.

  DEFINE STRUCTURE
  1 test_struct,
   3 el0  FILE VARIABLE ,  /* marked as error */
   3 el1  FILE VARIABLE,   /* marked as error + VARIABLE keyword is not colorized as keyword. */
   3 el2  PTR;

  DEFINE STRUCTURE
  1 test_struct,
   3 el2  PTR ,        /* ok */
   3 el20 PTR,         /* keyword not colorized */
   3 el3  PTR(32),     /* marked as error */
   3 el4  PTR(64),     /* marked as error */
   3 el5  HANDLE,      /* keyword not colorized */
   3 el50 HANDLE ,     /* ok */
   3 el6  HANDLE(32),  /* marked as error */
   3 el7  HANDLE(64);  /* marked as error */

 TPROC2: PROC(parm1)
            OPTIONS(FETCHABLE AMODE31 NODESCRIPTOR CMPAT(V2) LINKAGE(OPTLINK))
            EXTERNAL;

  DCL parm1 PTR;

 END TPROC2;

 // The CALLER_AMODE variable is passed using INCAFTER compile option where the included file 
 // contains the following line:
 // %DCL CALLER_AMODE FIXED INIT(64);  Feel free to uncomment to see what will change in that case
 %SELECT(CALLER_AMODE);  
 %WHEN(31) %DO;
  TPROC1: PROC(parm1)
            OPTIONS(FETCHABLE NODESCRIPTOR)
            EXTERNAL;
 %END;
 %WHEN(64) %DO;
  TPROC2: PROC(parm1)
            OPTIONS(FETCHABLE AMODE31 NODESCRIPTOR CMPAT(V2) LINKAGE(OPTLINK))
            EXTERNAL;
 %END;
 %OTHERWISE %DO;
   NOTE("Unsupported caller AMODE.", 12);
 %END;
 %END;

   DCL parm1 CHAR(*) VAR BYADDR INONLY;

 %SELECT(CALLER_AMODE);
 %WHEN(31) %DO;
  END TPROC1;
 %END;
 %WHEN(64) %DO;
  END TPROC2;
 %END;
 %OTHERWISE %DO;
   NOTE("Unsupported caller AMODE.", 12);
 %END;
 %END;