COBOL formatter - Errors formatting SQL statements - Githubissues

IBM / zopeneditor-about

IBM Z Open Editor: File issues here!

https://ibm.github.io/zopeneditor-about

Apache License 2.0

49 stars 20 forks source link

COBOL formatter - Errors formatting SQL statements #400

Closed FALLAI-Denis closed 4 months ago

FALLAI-Denis commented 5 months ago

Development environment used

Z Open Editor version: 4.1.0
Editor Platform
- [X] Visual Studio Code
- [ ] Red Hat CodeReady Workspaces
- [ ] Eclipse Che
- [ ] Standalone Theia
Editor Platform Version: 1.88.0
Operating System: Windows 10 22H2
Java Version: 1.7
[ ] Related to RSE API?
- RSE API Plugin version:
- Zowe CLI version:
- Node.js version:
Logs attached: no

Problem Description

The COBOL formatter incorrectly reformats the SQL statements included in the program.

Regarding SQL comments:

applies uppercase/lowercase conversions on these comments
does not recognize the sequence -- and transforms it into - - which makes the code uncompilable

In fact, the texmate grammar, like the COBOL language server, does not seem to manage comments included in SQL statements.

Regarding the management of parentheses:

the opening parenthesis is stuck to the word that precedes it; same problem seen on purely COBOL instructions using subscripted/indexed variables

Observed behavior

SQL comments:
Opening parenthesis

phaumer commented 4 months ago

We addressed this problem in v4.2.0. Let us know if this work for you.