search

IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
50 stars 20 forks source link

No syntax errors reported #420

Closed seporterfield closed 3 months ago

seporterfield commented 5 months ago

Development environment used

Problem Description

Detailed steps for reproducing the problem:

  1. Open a file written in COBOL with any detectable error, for example 
       IDENTIFICATION DIVISION.                
   PROGRAM-ID. TEST1.                       
   ENVIRONMENT DIVISION.                   
   DATA DIVISION.                          
   PROCEDURE DIVISION.                     
       DISPLAY "HELLO WORLD!"   
       FUNCTION NOTAFUNCTION("").    
       STOP RUN.

Observed behavior

Screenshot of version 4.3.0 image

Expected behavior

Screenshot of version 4.2.0: image

Note

I made sure to follow the instructions for resetting the extension's COBOL language server and VSCode before reproducing this behavior.

Russell-May commented 5 months ago

Hi, Thanks for reporting this issue. Unfortunately I have been unable to reproduce the issue. The only way I found to not have an error message displayed for the source that you provided is to Disable Problems in the settings. Can you verify that setting didn't get enabled? image

If the issue continues and that setting is not enabled, please provide your log file for the event.

seporterfield commented 5 months ago

The setting is not enabled.

image

Log file:

2024-06-19T17:26:03.282+02:00 INFO : Zowe Explorer was modified for IBM Remote System Explorer API (RSE API) support by IBM Z Open Editor.
2024-06-19T17:26:03.543+02:00 INFO : IBM Z Open Editor extension has (re)started
Russell-May commented 5 months ago

Thanks for verifying. Can you change your log level to DEBUG temporarily and re-upload the log after opening it again, INFO isn't providing any insight into what is going wrong. image

seporterfield commented 5 months ago

Logs with DEBUG enbled

v4.2.0

2024-06-19T17:42:53.829+02:00 DEBUG: TelemetryStats after restart: {"lastResetDate":"2024-06-17T22:11:31.164Z","numberOfEvents":202,"numberOfMaxEvents":0}
2024-06-19T17:42:53.831+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"activated","properties":{"editor":"Visual Studio Code"}}
2024-06-19T17:42:53.871+02:00 DEBUG: Zowe CLI Secure Credentials is active. Will initialize Z Open Editor to utilize it.
2024-06-19T17:42:53.884+02:00 DEBUG: Zowe CLI Secure Credentials is successfully activated for Z Open Editor.
2024-06-19T17:42:54.057+02:00 INFO : Zowe Explorer was modified for IBM Remote System Explorer API (RSE API) support by IBM Z Open Editor.
2024-06-19T17:42:54.065+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"licenses/state","properties":{"event.value":"trial-active","editor":"Visual Studio Code"}}
2024-06-19T17:42:54.067+02:00 DEBUG: ZAPP: No ZAPP file was found in /home/ziggy/Documents/Projects/zxplore. User and workspace settings will be used. Started watcher for when a zapp file does get created.
2024-06-19T17:42:54.068+02:00 DEBUG: ZCodeFormat: No zcodeformat file was found in /home/ziggy/Documents/Projects/zxplore. Formatter settings in other workspaces or the default formatter settings will be used. Started watcher for when a zcodeformat file does get created.
2024-06-19T17:42:55.025+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"java/found","properties":{"editor":"Visual Studio Code","platform":"linux","java.majorversion":"11","java.vendor":"openjdk"},"measurements":{"sinceActivated":1.196}}
2024-06-19T17:42:55.026+02:00 DEBUG: JavaFinder: Used the "command -v java" Linux command to locate Java.
2024-06-19T17:42:55.141+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"zowe/profileTypes","properties":{"event.value":"multiple","editor":"Visual Studio Code"}}
2024-06-19T17:42:55.184+02:00 DEBUG: Z Open Editor environment summary:
- Z Open Editor version: 4.2.0
- Editor platform: Visual Studio Code
- Editor platform version: 1.90.1
- Required minimal editor platform version: ^1.81.0
- Editor installation root directory: /snap/code/161/usr/share/code/resources/app
- Editor installation id: e78c9b6f3ab111d158fa8a68a63374503bb689571d769242b2728753b26e2e9a
- Editor workspaces: /home/ziggy/Documents/Projects/zxplore
- Is a valid Java configured: true
  - Java: /usr/lib/jvm/java-11-openjdk-amd64/bin/java
  - Java memory allocation: 512
  - Java startup user settings: Not defined.
- Key user settings:
  - Unreachable Code enabled: true
  - HLASM version used: 3.1
  - HLASM macros file used: 
  - HLASM instructions file used: /home/ziggy/.vscode/extensions/ibm.zopeneditor-4.2.0/resources/hlasm-instructions.json
  - HLASM Macro resolution enabled: false
  - HLASM Custom Macro Warnings enabled: true
  - HLASM Custom Macro Reduced Logging enabled: false
  - Enforce Case Sensitive Include File Names: false
  - ZAPP schema used: file:///home/ziggy/.vscode/extensions/ibm.zopeneditor-4.2.0/resources/zapp-schema-1.1.1.json
  - Variables defined by all ZAPP documents in workspace: 
  - Found the following ZAPP variable declarations in VS Code settings: []
  - Automatic preprocessor execution setting: off
  - IBM User Build enabled: true
  - Zowe CLI API profile management used: v2 team config in use.
  - Zowe CLI Secure Credentials enabled: true
  - Zowe data providers used: multiple
  - Zowe CLI profiles of types rse, zosmf or ssh found: zosmf(zosmf),rse(rse),ssh(ssh)
  - Zowe CLI files profile name specified in VS Code user settings: Not defined.
  - Zowe CLI SSH profile name specified in VS Code user settings: Not defined.
  - Zowe CLI files profile used for remote include files: rse
  - Zowe CLI SSH profile used: ssh
  - Zowe CLI profiles configured for user build: rse (rse)
  - Zowe Explorer RSE API Mappings File setting: Not defined.
  - Maximum number of parallel downloads over Zowe profiles: 5
  - Include file download strategy: Directly tries to download files from data sets.
  - Zowe Temp-Dir value: Not defined.
  - COBOL Property Groups defined: 
  - COBOL include file extensions: .cpy,.copybook,.copy,.cobcopy
  - COBOL disabled problems: false
  - PL/I Property Groups defined: 
  - PL/I include file extensions: .inc,.include,.plinc,.pcx,.pci
  - PL/I disabled problems: false
  - HLASM Property Groups defined: 
  - HLASM include file extensions: .s,.assemble,.asm,.hlasm,.hla,.copyasm,.macasm,.bms,.mac
  - HLASM disabled problems: false
  - REXX disabled problems: false
  - VS Code Files Associations: *.COBOL*:cobol,*.COB*:cobol,*.COBCOPY*:cobol,*.COPYBOOK*:cobol,*.COPY*:cobol,*.PL1*:pl1,*.PLI*:pl1,*.INC*:pl1,*.INCLUDE*:pl1,*.JCL*:jcl,*.ASM*:hlasm,*.ASSEMBLE*:hlasm,*.HLASM*:hlasm,*.HLA*:hlasm,*.MACLIB*:hlasm,*.EXEC*:rexx,*.REXX*:rexx,*.REXXINC*:rexx,*.rex:rexx,*.rexx:rexx,*.CBL*:cobol
- Zowe Explorer VS Code Extension version: 2.16.2
  - Successfully activated: true
  - Installation path: /home/ziggy/.vscode/extensions/zowe.vscode-extension-for-zowe-2.16.2
  - Log file location: /home/ziggy/.vscode/extensions/zowe.vscode-extension-for-zowe-2.16.2/logs
- Other VS Code extensions visible: vscode.bat(1.0.0),vscode.clojure(1.0.0),vscode.coffeescript(1.0.0),vscode.configuration-editing(1.0.0),vscode.cpp(1.0.0),vscode.csharp(1.0.0),vscode.css(1.0.0),vscode.css-language-features(1.0.0),vscode.dart(1.0.0),vscode.debug-auto-launch(1.0.0),vscode.debug-server-ready(1.0.0),vscode.diff(1.0.0),vscode.docker(1.0.0),vscode.emmet(1.0.0),vscode.extension-editing(1.0.0),vscode.fsharp(1.0.0),vscode.git(1.0.0),vscode.git-base(1.0.0),vscode.github(0.0.1),vscode.github-authentication(0.0.2),vscode.go(1.0.0),vscode.groovy(1.0.0),vscode.grunt(1.0.0),vscode.gulp(1.0.0),vscode.handlebars(1.0.0),vscode.hlsl(1.0.0),vscode.html(1.0.0),vscode.html-language-features(1.0.0),vscode.ini(1.0.0),vscode.ipynb(1.0.0),vscode.jake(1.0.0),vscode.java(1.0.0),vscode.javascript(1.0.0),vscode.json(1.0.0),vscode.json-language-features(1.0.0),vscode.julia(1.0.0),vscode.latex(1.0.0),vscode.less(1.0.0),vscode.log(1.0.0),vscode.lua(1.0.0),vscode.make(1.0.0),vscode.markdown(1.0.0),vscode.markdown-language-features(1.0.0),vscode.markdown-math(1.0.0),vscode.media-preview(1.0.0),vscode.merge-conflict(1.0.0),vscode.microsoft-authentication(0.0.1),ms-vscode.js-debug(1.90.0),ms-vscode.js-debug-companion(1.1.2),ms-vscode.vscode-js-profile-table(1.0.9),vscode.builtin-notebook-renderers(1.0.0),vscode.npm(1.0.1),vscode.objective-c(1.0.0),vscode.perl(1.0.0),vscode.php(1.0.0),vscode.php-language-features(1.0.0),vscode.powershell(1.0.0),vscode.pug(1.0.0),vscode.python(1.0.0),vscode.r(1.0.0),vscode.razor(1.0.0),vscode.references-view(1.0.0),vscode.restructuredtext(1.0.0),vscode.ruby(1.0.0),vscode.rust(1.0.0),vscode.scss(1.0.0),vscode.search-result(1.0.0),vscode.shaderlab(1.0.0),vscode.shellscript(1.0.0),vscode.simple-browser(1.0.0),vscode.sql(1.0.0),vscode.swift(1.0.0),vscode.theme-abyss(1.0.0),vscode.theme-defaults(1.0.0),vscode.theme-kimbie-dark(1.0.0),vscode.theme-monokai(1.0.0),vscode.theme-monokai-dimmed(1.0.0),vscode.theme-quietlight(1.0.0),vscode.theme-red(1.0.0),vscode.vscode-theme-seti(1.0.0),vscode.theme-solarized-dark(1.0.0),vscode.theme-solarized-light(1.0.0),vscode.theme-tomorrow-night-blue(1.0.0),vscode.tunnel-forwarding(1.0.0),vscode.typescript(1.0.0),vscode.typescript-language-features(1.0.0),vscode.vb(1.0.0),vscode.xml(1.0.0),vscode.yaml(1.0.0),adpyke.codesnap(1.3.4),alexcvzz.vscode-sqlite(0.14.1),bradlc.vscode-tailwindcss(0.10.5),charliermarsh.ruff(2024.26.0),dbaeumer.vscode-eslint(3.0.10),eamodio.gitlens(15.1.0),esbenp.prettier-vscode(10.4.0),george-alisson.html-preview-vscode(0.2.5),GitHub.remotehub(0.62.0),github.vscode-github-actions(0.26.3),GitHub.vscode-pull-request-github(0.90.0),Hridoy.rails-snippets(1.0.8),IBM.zopeneditor(4.2.0),marp-team.marp-vscode(2.8.0),me-dutour-mathieu.vscode-github-actions(3.0.1),ms-azure-devops.azure-pipelines(1.228.0),ms-azuretools.vscode-azureresourcegroups(0.9.1),ms-azuretools.vscode-docker(1.29.1),ms-python.debugpy(2024.6.0),ms-python.python(2024.8.1),ms-python.vscode-pylance(2024.6.1),ms-toolsai.jupyter(2024.5.0),ms-toolsai.jupyter-keymap(1.1.2),ms-toolsai.jupyter-renderers(1.0.18),ms-toolsai.vscode-jupyter-cell-tags(0.1.9),ms-toolsai.vscode-jupyter-slideshow(0.1.6),ms-vscode-remote.remote-containers(0.369.0),ms-vscode-remote.remote-ssh(0.112.0),ms-vscode-remote.remote-ssh-edit(0.86.0),ms-vscode.azure-account(0.12.0),ms-vscode.azure-repos(0.38.0),ms-vscode.makefile-tools(0.9.10),ms-vscode.remote-explorer(0.4.3),ms-vscode.remote-repositories(0.40.0),ms-vsliveshare.vsliveshare(1.0.5932),njpwerner.autodocstring(0.6.1),redhat.vscode-yaml(1.15.0),Shopify.ruby-lsp(0.7.5),tomoki1207.pdf(1.2.2),tonybaloney.vscode-pets(1.27.0),Zowe.vscode-extension-for-zowe(2.16.2)
2024-06-19T17:43:21.766+02:00 DEBUG: ZLanguageServer.buildServerOptions: Starting COBOL language server from "language-server".
2024-06-19T17:43:21.793+02:00 DEBUG: ZLanguageServer: Will start a language server with command "/usr/lib/jvm/java-11-openjdk-amd64/bin/java -Declipse.application=com.ibm.wazi.lsp.cobol.core.languageServer,-Dosgi.bundles.defaultStartLevel=4,-Declipse.product=com.ibm.wazi.lsp.cobol.core.languageServerProduct,-Xmx512m,-jar,/home/ziggy/.vscode/extensions/ibm.zopeneditor-4.2.0/language-server/plugins/org.eclipse.equinox.launcher_1.6.400.v20210924-0641.jar,-configuration,/home/ziggy/.vscode/extensions/ibm.zopeneditor-4.2.0/language-server/cobol_config_linux,-data,/tmp/_ws_1718811801793".
2024-06-19T17:43:21.815+02:00 DEBUG: AbstractZLanguageClient.initializeLanguageClient: Started initializing a new COBOL language client with these initialization options: {"enableUnreachableCodeWarnings":true,"publishDiagnostics":true,"includeFileExtensions":[".cpy",".copybook",".copy",".cobcopy"],"compilerOptions":"","commercialFeaturesEnabled":true}.
2024-06-19T17:43:21.826+02:00 DEBUG: AbstractZLanguageClient.startLanguageClient: Language client for COBOL started.
2024-06-19T17:43:23.740+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"document/didOpen","properties":{"editor":"Visual Studio Code","language":"cobol"},"measurements":{"sinceActivated":29.911}}

v4.3.0

2024-06-19T17:47:59.543+02:00 DEBUG: TelemetryStats after restart: {"lastResetDate":"2024-06-17T22:11:31.164Z","numberOfEvents":210,"numberOfMaxEvents":0}
2024-06-19T17:47:59.545+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"activated","properties":{"editor":"Visual Studio Code"}}
2024-06-19T17:47:59.568+02:00 DEBUG: Zowe CLI Secure Credentials is active. Will initialize Z Open Editor to utilize it.
2024-06-19T17:47:59.577+02:00 DEBUG: Zowe CLI Secure Credentials is successfully activated for Z Open Editor.
2024-06-19T17:47:59.683+02:00 INFO : Zowe Explorer was modified for IBM Remote System Explorer API (RSE API) support by IBM Z Open Editor.
2024-06-19T17:47:59.698+02:00 DEBUG: UsageReporter: Sending the following telemetry data: {"eventName":"licenses/state","properties":{"event.value":"trial-active","editor":"Visual Studio Code"}}
2024-06-19T17:47:59.700+02:00 DEBUG: ZAPP: No ZAPP file was found in /home/ziggy/Documents/Projects/zxplore. User and workspace settings will be used. Started watcher for when a zapp file does get created.
2024-06-19T17:47:59.701+02:00 DEBUG: ZCodeFormat: No zcodeformat file was found in /home/ziggy/Documents/Projects/zxplore. Formatter settings in other workspaces or the default formatter settings will be used. Started watcher for when a zcodeformat file does get created.
2024-06-19T17:47:59.946+02:00 DEBUG: Z Open Editor environment summary:
- Z Open Editor version: 4.3.0
- Editor platform: Visual Studio Code
- Editor platform version: 1.90.1
- Required minimal editor platform version: ^1.81.0
- Editor installation root directory: /snap/code/161/usr/share/code/resources/app
- Editor installation id: e78c9b6f3ab111d158fa8a68a63374503bb689571d769242b2728753b26e2e9a
- Editor workspaces: /home/ziggy/Documents/Projects/zxplore
2024-06-19T17:48:00.056+02:00 INFO : IBM Z Open Editor extension has (re)started.
Russell-May commented 5 months ago

Thank you for the logs. It looks like your language server isn't starting in the background for some reason. One thing that stands out to me is that there were no "java/found" event triggers. This leads me in the direction of the extension not properly finding your java for some reason (not your fault the java version you listed is supported). Can you verify for me that on the Welcome page that we indicate that we were able to locate your JDK? If you have disabled the Welcome page you can open it manually from the command pallet with the command IBM Z Open Editor: Welcome

image

seporterfield commented 5 months ago

v4.2.0

image image

v4.3.0

The prerequisites are stuck loading. image

Russell-May commented 5 months ago

Thanks for the update. This makes me think there is a bug in our Java location and validation logic that was introduced this release. To verify (and hopefully unblock you while we fix the bug) can you set your "zopeneditor.JAVA_HOME" value in your user settings to "/usr/lib/jvm/java-11-openjdk-amd64". Please let me know that results in us locating the Java and the language server starting as expected.

seporterfield commented 5 months ago

Yes! That fixes it immediately.

The extension found java, the language server started, and syntax errors started getting reported again.

Russell-May commented 5 months ago

Wonderful, I'm glad that fixed the issue. I'm going to tag this issue as a bug so we can get that fixed. Thanks for the feedback!

phaumer commented 3 months ago

We fixed the issue in v.4.4.0. Can you try again without the setting and let us know?