search

IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
50 stars 20 forks source link

RSE profiles not returning members with Zowe Explorer member filter search #426

Closed JillieBeanSim closed 3 months ago

JillieBeanSim commented 4 months ago

Porting issue for RSE type profiles:

Greetings,

The problem

Trying to Retrieve members with a filter in populous datasets doesn't return the expected results. The magnitude is around ten thousand for the particular dataset where the problem was detected.

Issue 1270 looks similar, but this issue doesn't talk about filters.

Error recreation

Recreation requires a dataset with thousands of member. I will name such dataset "TEST.DS". Assume this dataset has an even spread of members in alphabetical ordering.

  • Navigate to Zowe Explorer tree view
  • Open contextual menu in profile
  • Select "Filter PDS members"
  • Search for "TEST.DS(Q*)"

Result is:

No results are returned.

Expected result is:

Results are returned and start with "Q"

Next is a recreation of the error in our environment: filter_dataset-error filter_dataset-error

Ancillary tests

Under hundred members dataset

Assume dataset "LIGHT.DS" with less than 100 members.

  • Navigate to Zowe Explorer tree view
  • Open contextual menu in profile
  • Select "Filter PDS members"
  • Search for "LIGHT.DS(Q*)"

Result is:

Results are returned and start with "Q".

Curl call

Assume dataset "TEST.DS". More than a thousand members. this dataset has an even spread of members in alphabetical ordering.

Use the following curl (replace what is needed):

curl -X 'GET' '{{mainframehost}}/rseapi/api/v1/datasets/search/PDSMembers?filter={{TEST.DS}}&memberPattern=Q%2A' -H 'accept: application/json' -H 'Authorization: {{auth}}' -H 'Number-Of-Results: 50000'

Result is:

Results are returned and start with "Q"

Recreation in our environment: filter_dataset-curl filter_dataset-curl

Miscelaneous data

  • OS: Windows_NT x64 10.0
  • Zowe Explorer Version: 2.16.2
  • Zowe CLI Version: 7.13.0

When we call the server through VS Code, the server registered this entry:

--------------- - - [---------------------] "GET /rseapi/api/v1/datasets/search/PDSMembers?filter=CMN.ABASE.CPY&memberPattern=* HTTP/1.1" 200

Otherwise, with curl, the server entry is:

--------------- - - [---------------------] "GET /rseapi/api/v1/datasets/search/PDSMembers?filter=CMN.ABASE.CPY&memberPattern=Q* HTTP/1.1" 200

We believe the filtering is happening client-side in the explorer and that is what is causing the bug since there is a limit of items fetched.

Development environment used

Problem Description

Detailed steps for reproducing the problem:

  1. First step

Observed behavior

-

Expected behavior

-

likhithanimma1 commented 3 months ago

Needed more info regarding the products of versions require for investigation? RSE API server and Z Open Editor

antonkc commented 3 months ago

Here it is: ibm.zopeneditor 4.3.0 zowe.vscode-extension-for-zowe 2.17.0 RSE API 3.3.0.0

likhithanimma1 commented 3 months ago

Here it is: ibm.zopeneditor 4.3.0 zowe.vscode-extension-for-zowe 2.17.0 RSE API 3.3.0.0

Hey @antonkc Can you update to the latest version of RSEAPI? The latest one would be part of z/OS Explorer 3.3.5. and confirm that if you are still seeing the issue

antonkc commented 3 months ago

Greetings @likhithanimma1 ,

Updated the versions. The same error happens. Same characteristics. By the way, it also happens in ZOSMF.

JillieBeanSim commented 3 months ago

Thanks for the information @antonkc. Hey @likhithanimma1 if this is verified to be an issue with zosmf type profiles too, we should be able to reopen the ZE issue this was ported from for a resolution since it's not rse type profile specific.

likhithanimma1 commented 3 months ago

Closing this issue and reopening the issue https://github.com/zowe/zowe-explorer-vscode/issues/2978 for resolution where it is ported from as it is not only specific with rse but also with zosmf .