IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
50 stars 20 forks source link

when vscode restarts with a remote file in the active tab, it would never resync with the remote source. #440

Closed alexbodn closed 3 weeks ago

alexbodn commented 1 month ago

Development environment used

Problem Description

Detailed steps for reproducing the problem:

  1. First step

Observed behavior

now i see that i was complaining about the smaller problem:

Expected behavior

phaumer commented 1 month ago

Did you check the zowe.files.temporaryDownloadsFolder.cleanup setting? We had the "security" requirement that when Z Open Editor shuts down that there should be no source files left on the local system, so all temporary downloads will be cleaned up at shutdown and startup (in case the editor crashed). With this setting you can prevent the cleaning part.

However, for Zowe Explorer v3 temporary file storage will be replaced with a new mechanism using vscode.FileSystemProvider. Will update here with more details once I collected them all, however, this is definitely a discussion for the Zowe Explorer team and less Z Open Editor.

alexbodn commented 1 month ago

Thank you peter for your answer. the files surviving the security cleanup you mentioned are exactly the files that vscode have saved to the temp location, but didn't make it to the z. so i think it's good the file wasn't deleted, and the user should have a chance to review the changes from the version on the mainframe. otherwise, we'll be an accomplice with the crash.

On Mon, Sep 16, 2024 at 10:50 PM Peter Haumer @.***> wrote:

Did you check the zowe.files.temporaryDownloadsFolder.cleanup setting? We had the "security" requirement that when Z Open Editor shuts down that there should be no source files left on the local system, so all temporary downloads will be cleaned up at shutdown and startup (in case the editor crashed). With this setting you can prevent the cleaning part.

However, for Zowe Explorer v3 temporary file storage will be replaced with a new mechanism using vscode.FileSystemProvider. Will update here with more details once I collected them all, however, this is definitely a discussion for the Zowe Explorer team and less Z Open Editor.

— Reply to this email directly, view it on GitHub https://github.com/IBM/zopeneditor-about/issues/440#issuecomment-2353785719, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABER7AIIQ7NU44TBMFMFLCDZW4ZBJAVCNFSM6AAAAABOE4VYWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTG44DKNZRHE . You are receiving this because you authored the thread.Message ID: @.***>

--

alex

phaumer commented 3 weeks ago

Zowe Explorer 3 is now available and it reloads the contents from the remote location after restart.