IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
51 stars 20 forks source link

zapp.yaml (COBOL) - Wrongly replacing the existing file with the default file #444

Closed FALLAI-Denis closed 1 month ago

FALLAI-Denis commented 2 months ago

Development environment used

Problem Description

We note on some VS Code Workspaces (mono root folder), but not all, corresponding to Git Repositories, that the zapp.yaml file present in this Workspace is wrongly replaced by the default zapp.yaml file, which then creates errors in the search for copybooks, generates errors at the Language Server level, and in fact deactivates many features of Z Open Editor.

This problem seems to be related to timeout issues in VS Code, which can have several origins:

The local folders to scan for copybooks are populated by importing (git clone / fetch / sparse-checkout) other Git repositories containing copybooks. These imported Git repositories can themselves contain zapp.yaml files.

The problem appears when the number of Git repositories imported into the folder declared in zapp.yaml increases.

The zapp.yaml file can be wrongly overwritten even after starting VS Code, apparently when opening a new COBOL file, which triggers a copybook search, and thus probably a search for the zapp.yaml file.

The workaround was to disable the automatic creation of the zapp.yaml file when it is missing, (but in our case it is not missing, it is just not detected by Z Open Editor).

Thanks.

image

image

image

image

image

phaumer commented 1 month ago

We added an existence check in 5.0.0 to avoid overwriting the file.

FALLAI-Denis commented 1 month ago

Hi @phaumer,

Thank you. However, in our context we will disable the automatic creation of the zapp.yaml file. There is no reason why it should not exist, and we think it is preferable for our developers to ask us about its absence rather than working with a zapp.yaml file that does not correspond to our operating context.

Maybe we will reactivate the automatic creation when the next request is delivered:

Thanks.