IBM / zopeneditor-about

IBM Z Open Editor: File issues here!
https://ibm.github.io/zopeneditor-about
Apache License 2.0
51 stars 20 forks source link

IBM Z open editor not recognizing file associations and zopeneditor.datasets.jclDatasets #457

Open Madhubalan-p opened 2 weeks ago

Madhubalan-p commented 2 weeks ago

IBM Z open editor not recognizing file associations and zopeneditor.datasets.jclDatasets

Development environment used

Problem Description

After updating to new version of IBM z open editor-v5.0.0, if I open a member from a dataset called myuser.JCLS from zowe explorer, ibm z open editor is not interpreting it as jcl even though i have declared the files.associations in vscode user settings file (".JCL": "jcl",".JCLS": "jcl",). it is instead interpreting it is as a normal text file. tried both files.associations and "zopeneditor.datasets.jclDatasets". none of them is working.

Detailed steps for reproducing the problem:

  1. First step

IBM z open editor is not interpreting a member from a dataset as jcl even though the file associations and zopeneditor.datasets.jclDatasets have been updated as per dataset name.

-

IBM z open editor is not interpreting a member from a dataset as jcl after defining file associations and zopeneditor.datasets.jclDatasets as per dataset name.

-

benjamin-t-santos commented 2 weeks ago

Hi @Madhubalan-p, Would you mind sharing the version of Zowe Explorer that you are using? In v3, Zowe Explorer switched from using on-disk storage for programs to a virtual file system. This could have affected how Zowe Explorer assigns file extensions to files opened in the tree views.

Madhubalan-p commented 2 weeks ago

Hi @benjamin-t-santos , I am using the new version of zowe explorer-v3.0.2.

benjamin-t-santos commented 2 weeks ago

Hi @Madhubalan-p, As I expected, the Zowe v3 filesystem is the source of these issues. The new file system has a different path structure for data sets and members. Before, the member name was inserted into the file path in parentheses (ex: MYUSER.JCLS(MEMBER)), but now members are added as a new path segment (ex: MYUSER.JCLS/MEMBER). You will need to adjust your file.associations to support the new format.

Here is a glob pattern you can try in your file.associations to account for the new v3 path format:

Let me know if that works for you.

We would like to improve the user experience and avoid situations like this in the future by making Zowe Explorer language agnostic and giving extenders control over how files are associated. Please consider upvoting this issue: https://github.com/zowe/zowe-explorer-vscode/issues/3131

Madhubalan-p commented 2 weeks ago

thanks @benjamin-t-santos . your suggestion works fine. would be great if the documentation of ibm z open editor is updated also.

phaumer commented 2 weeks ago

Marking it as an enhancement for our docs.