search

IBMRob / node-red-contrib-1wire

Apache License 2.0
4 stars 5 forks source link

negative temps #2

Open nate8199 opened 7 years ago

nate8199 commented 7 years ago

I'm having issues with negative temperatures, they aren't reading correctly, and they don't work if I select the Fahrenheit option.

IBMRob commented 7 years ago

When you say aren't reading correctly can you provide a bit more information i.e. is it over/under reading by a lot, a little etc?

Regarding the Fahrenheit option - do you get any errors in your NodeRed logs?

nate8199 commented 7 years ago

I actually found another node I'm trying, node-red-contrib-ds18b20-sensor, along with a function to convert to Fahrenheit, it simplified my layout some this way also.

I will try and set it up to provide a reading from both your node and this newer one.

On Dec 14, 2016 1:23 AM, "RobQuads" notifications@github.com wrote:

When you say aren't reading correctly can you provide a bit more information i.e. is it over/under reading by a lot, a little etc?

Regarding the Fahrenheit option - do you get any errors in your NodeRed logs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RobQuads/node-red-contrib-1wire/issues/2#issuecomment-266972114, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJpRDR412SnKpu6pbvbd9F_X5PWgwxKks5rH6dlgaJpZM4LMfoX .

freddy4th commented 6 years ago

I’ve had the same issue. Negative temps just come through as positive

cuetus commented 3 years ago

The regex does not match negative numbers ie t=-1234 1Wire.js change data.match(/t=(\d)/) to data.match(/t=(-?\d)/) and it works.