IBMStockTrader / portfolio

Microservice implemented with MicroProfile that persists stock portfolios to JDBC (such as DB2)
Apache License 2.0
7 stars 60 forks source link

Private keys should not be checked into github, or baked into docker image. #12

Open BarDweller opened 5 years ago

BarDweller commented 5 years ago

Keys for microservices should be supplied as configuration via k8s secrets, having them present in github kinda defeats the purpose of them being secret.

This is a placeholder issue to track removal of the keys, updating the project to use k8s secret provisioned keys, and adding the documentation to cover the creation of the secrets.