search

IBMStockTrader / trade-history

Microservice that keeps a detailed history of all stock trades
Apache License 2.0
1 stars 19 forks source link

Add kafka status to health check #46

Closed evie-lau closed 5 years ago

evie-lau commented 5 years ago

Found an issue where the logging output rate keeps growing until the application runs out of resources.

image

yeekangc commented 5 years ago

@kevinwlau, do we really need the beans.xml?

evie-lau commented 5 years ago

@kevinwlau, do we really need the beans.xml?

Yes, I tested without the beans.xml and CDI doesn't work properly. End up with a NullPointer when trying to access the injected Consumer

I may be able to change the discovery mode to annotated to be more strict. But I think the beans.xml file is still necessary. Edit: using annotated didn't work

yeekangc commented 5 years ago

Should look into that further but will take the changes.