Closed anouri closed 6 years ago
I think this is a great addition to IBMStreams. streamsx.social uses HTTPGetStream to get data from Twitter.
In this proposal, the project uses Twitter4J (https://github.com/yusuke/twitter4j) to send tweets. We may eventually want to converge on a single approach for this to be more consistent.
Can you elaborate on why you want a separate repository from streamsx.social? I understand the concerns about namespace changes.
But other than that what are your other concerns with contributing to the streamsx.social repository? Is it the name of the project? You envision the new repository to evolve in such a way that it needs to be separated?
Thanks!
How are you licencing the code in https://github.com/anouri/streamsx.twitter ?
+1 to the code being added to streamsx.social, assuming the code can be licenced under ALv2.
All projects under IBMStreams are under Apache v2 license.
Shall I add a new LICENCE file with this content?
Twitter4J is released under Apache License 2.0. Copyright 2007 Yusuke Yamamoto Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software Distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+1 to this being added to streamsx.social
I don't think we need to add the license file. From looking at the project, you have asked user to download this from Twitter4J, and we are re-distributing its code or binary.
You may want to look into using maven to download the dependency for user, if that is possible.
To answer @ddebrunner question, Twitter4J is also under Apache v2 license.
My question was not what twitter4j is licenesed under, but what the code @anouri is providing is licensed under.
+1 to be part of streamsx.social.
+1 to being part of streamsx.social or converting streamsx.social to streamsx.twitter. This repository is currently only Twitter related, so renaming could make Twitter operators more visible and easier to find.
Ok, I think we are in consensus to have one toolkit for twitter functions. Correct?
+1 on @Alex-Cook4 idea to rename streamsx.social to streamsx.twitter and include this content in the same toolkit. I think it provides more visibility and will allow us to be more flexible in the long run. I think it is better for us to have smaller and specific toolkits, rather than having a big toolkit than contains many different kinds of operators.
Please advise.
@anouri If you are intending to release your code (yusuke/twitter4j) under the Apache licence then you should just add the Apache Licence as LICENSE.md.
I think if you create LICENSE.md from the browser at github then it will prompt you to select from existing files.
Hi Dan I have created a new LICENCE.md file. Please check it and let me know if if any changes needed. The repository streamsx.twitter is temporary under https://github.com/anouri/streamsx.twitter. After transfer this project into https://github.com/IBMStreams, I can remove it from https://github.com/anouri/.
@anouri
You added a licence file saying how Twitter4j is licenced, that's not the issue.
What is required is how you are licencing your code.
If you are intending to release your code (yusuke/twitter4j) under the Apache licence then you should just add the Apache Licence as LICENSE.md.
@ddebrunner I am a bit confused. If @anouri is to contribute the code to streamsx.social, and it is already licensed with Apache, why would he need to add a license.md. Twitter4J is a separate project that people will have to download. In my understanding, we are not distributing code from it.
In short, I think we can just create a pull request from streamsx.social to pull the code in.
User will download Twitter4J separate as described in the readme. In the future, we may want to use Maven to pull in the dependency.
Please correct me if my understanding is incorrect.
@chanskw It's because @anouri's code already exists, separate to streamsx.social. Since the code that is copied into the streamsx.social toolkit will be a copy of @anouri's code, what gave the person copying it the right to copy it?
Had it been contributed to streamsx.social as a change to that toolkit (using fork/clone/pull request) then it would have been covered by the LICENCE.md in streamsx.social. (as well as the ICLA).
@anouri what are your thoughts on this?
Any updates here?
Cancelling due to lack of activity. Please reopen if you would like to contribute again.
I have developed a new JAVA operator to send a direct message from a twitter account to other. https://github.com/anouri/streamsx.twitter I propose to insert this toolkit in the https://github.com/IBMStreams.
Samantha recommended to insert this toolkit into already existing project streamsx.social.
Please check the README.md file and the namespaces of toolkit and let me know if any changes needed.
I have already a project in the sample repository. https://github.com/IBMStreams/samples/tree/master/DbLoader