search

IBMStreams / build-ibmstreams

IBM Streams build extension for Atom
https://atom.io/packages/build-ibmstreams
Apache License 2.0
0 stars 3 forks source link

Improve error handling when the build service fails or returns unexpected format for data #10

Closed guychris closed 6 years ago

guychris commented 6 years ago

In a scenario where the build submission returned undefined for build id and output_id, the subsequent message parsing for build status failed when the expected message output array was undefined.

Need to improve robustness when unexpected format for data is received or when build service does not return successfully.

spl-build-common.js? [sm]:152 submitting application to build service spl-build-common.js? [sm]:64 2258 total bytes spl-build-common.js? [sm]:65 Application source archive built spl-build-common.js? [sm]:350 submitSourceBundleObservable input: {filename: “/xxxxxxxx/bundle.zip”} spl-build-common.js? [sm]:170 app source has been submitted... spl-build-common.js? [sm]:333 pollBuildStatusObservable input: {filename: “/xxxxxxx/bundle.zip”, id: undefined, output_id: undefined} spl-build-common.js? [sm]:333 pollBuildStatusObservable input: {filename: “/xxxxxxx/___bundle.zip”, id: undefined, output_id: undefined, trace: “caa90f2506a1460b9606565898971795", errors: Array(1)} spl-build-common.js? [sm]:175 build error TypeError: Cannot read property ‘length’ of undefined at SplBuilder.getNewBuildOutput (spl-build-common.js? [sm]:218) at TapSubscriber._tapNext (spl-build-common.js? [sm]:210) at TapSubscriber._next (tap.ts:111) at TapSubscriber.Subscriber.next (Subscriber.ts:101) at MapSubscriber._next (map.ts:86) at MapSubscriber.Subscriber.next (Subscriber.ts:101) at DebounceTimeSubscriber.debouncedNext (debounceTime.ts:110) at DebounceTimeSubscriber._complete (debounceTime.ts:94) at DebounceTimeSubscriber.Subscriber.complete (Subscriber.ts:128) at Request._callback (spl-build-common.js? [sm]:408) at Request.self.callback (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:185) at emitTwo (events.js:126) at Request.emit (events.js:214) at Request. (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:1161) at emitOne (events.js:116) at Request.emit (events.js:211) at IncomingMessage. (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:1083) at Object.onceWrapper (events.js:313) at emitNone (events.js:111) at IncomingMessage.emit (events.js:208) at endReadableNT (_stream_readable.js:1056) at _combinedTickCallback (internal/process/next_tick.js:138) at process._tickCallback (internal/process/next_tick.js:180) MessageHandler.js? [sm]:94 TypeError: Cannot read property ‘length’ of undefined at SplBuilder.getNewBuildOutput (spl-build-common.js? [sm]:218) at TapSubscriber._tapNext (spl-build-common.js? [sm]:210) at TapSubscriber._next (tap.ts:111) at TapSubscriber.Subscriber.next (Subscriber.ts:101) at MapSubscriber._next (map.ts:86) at MapSubscriber.Subscriber.next (Subscriber.ts:101) at DebounceTimeSubscriber.debouncedNext (debounceTime.ts:110) at DebounceTimeSubscriber._complete (debounceTime.ts:94) at DebounceTimeSubscriber.Subscriber.complete (Subscriber.ts:128) at Request._callback (spl-build-common.js? [sm]:408) at Request.self.callback (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:185) at emitTwo (events.js:126) at Request.emit (events.js:214) at Request. (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:1161) at emitOne (events.js:116) at Request.emit (events.js:211) at IncomingMessage. (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/request/request.js:1083) at Object.onceWrapper (events.js:313) at emitNone (events.js:111) at IncomingMessage.emit (events.js:208) at endReadableNT (_stream_readable.js:1056) at _combinedTickCallback (internal/process/next_tick.js:138) at process._tickCallback (internal/process/next_tick.js:180)

guychris commented 6 years ago

fixes delivered to develop branch to improve error handling, we now catch build service error returns and prompt a user with a button to open the bluemix console if the streaming analytics service is not started.