IBMStreams / streamsx.health

(Incubation) Streams Healthcare Analytics Platform - To enable and inspire the next generation healthcare solutions
https://github.com/IBMStreams/streamsx.health/wiki
Apache License 2.0
41 stars 34 forks source link

Consider support Streams v4.1 #119

Open chanskw opened 7 years ago

chanskw commented 7 years ago

To support Streams 4.1

  1. Update toolkits in product:

The following toolkits need to be available in the Streams_Install/toolkits directory: streamsx.datetime.toolkits-1.1.2.commit_ed502a8-20160930-1439.tgz streamsx.json.toolkits-1.2.1.commit_cc3b08f-20160815-1035.tgz streamsx.messaging.toolkits-5.0.0-20160609-1840.tgz streamsx.topology-v1.6-20170327-1453.tgz

  1. EWSScore service can be built but the Rules cannot be updated:

Rules from EWSSCore service cannot be modified since Streams 4.1 does not ship with the Rules Compiler.

  1. Physionet service cannot be built due to the following error:

For physionet service, the following method is not found in Streams 4.1:src/function/com/ibm/streamsx/health/ingest/physionet/service/LOAD_CODE_MAP.cpp: In function \u2018SPL::map<SPL::rstring, SPL::rstring> com::ibm::streamsx::health::ingest::physionet::service::LOAD_CODE_MAP()\u2019: src/function/com/ibm/streamsx/health/ingest/physionet/service/LOAD_CODE_MAP.cpp:12:114: error: \u2018getToolkitDirectory\u2019 was not declared in this scope const SPL::rstring id$mapfile = (getToolkitDirectory(SPL::rstring("com.ibm.streamsx.health.ingest.physionet")) + SPL::rstring("/etc/codemap.csv")); ^ make: [build/function/com/ibm/streamsx/health/ingest/physionet/service/LOAD_CODE_MAP.o] Error 1 make: Waiting for unfinished jobs.... CDISP0141E ERROR: The compilation of the generated code failed. :ingest:physionet:com.ibm.streamsx.health.ingest.physionet:buildServices FAILED

  1. PatientMonitoring Sample cannot be built:

:ingest:vines:com.ibm.streamsx.health.vines:build :samples:PatientsMonitoringDemo.rules:com.ibm.streamsx.health.sample.patientsmonitoring.rules:assemble UP-TO-DATE :samples:PatientsMonitoringDemo.rules:com.ibm.streamsx.health.sample.patientsmonitoring.rules:buildServices CDISP0727W WARNING: The /home/chanskw/InfoSphere_Streams_release/4.1.1.2/toolkits/com.ibm.streams.rulescompiler input path is not a directory. CDISP0383E ERROR: The com.ibm.streamsx.health.sample.patientmonitoring.rules toolkit requires InfoSphere Streams version 4.2.0.0, but version 4.1.1.2 of the product is currently installed. CDISP0385E ERROR: The com.ibm.streamsx.health.sample.patientmonitoring.rules toolkit requires version 1.0.0 of the com.ibm.streams.rulescompiler toolkit, but version 1.0.0 of the com.ibm.streams.rulescompiler toolkit is not available. CDISP0131E ERROR: Errors occurred while the toolkits were loading. :samples:PatientsMonitoringDemo.rules:com.ibm.streamsx.health.sample.patientsmonitoring.rules:buildServices FAILED

jms90h5 commented 7 years ago

+1 on supporting newer versions of Streams, although I'd bump it up to the latest version available on fix central (4.2.0.3 or 4.2.0.4 depending on when this gets addressed