search

IBMStreams / streamsx.messaging

This toolkit is focused on interacting with popular messaging systems such as Kafka, JMS, XMS, and MQTT. After release v5.4.2 the complete toolkit will be deprecated. See the README.md file for hints to alternative toolkits.
http://ibmstreams.github.io/streamsx.messaging/
Apache License 2.0
30 stars 32 forks source link

RELEASE PROPOSAL: 4.x Branch Release proposal #207

Closed Alex-Cook4 closed 6 years ago

Alex-Cook4 commented 8 years ago

I would like to do a release of the 4.x branch. Reason: The 4.x branch now has extensively tested versions of RabbitMQ and Kafka.

Propose deletion of the following obsolete branches that were done for Message Hub:

Title: Messaging Toolkit v4.0.0 Message Hub Release Tag: v4.0.0 List of Enhancements:

This release does not support Kafka 0.8 servers.

Please vote +1 to approve.

ddebrunner commented 8 years ago

Having so many versions of the toolkit with the same 4.0.0 version makes it very confusing.

chanskw commented 8 years ago

Is this request still valid? Did we create a release without finishing a vote?

Alex-Cook4 commented 8 years ago

There has not been a release. This request is still valid. I agree it is confusing, so I think doing this release and then deleting the other alphas will be helpful.

ddebrunner commented 8 years ago

Is it possible to ensure that the third element of the version is bumped when minor changes are made, there's no requirement for the official first release of a branch be 4.0.0.

chanskw commented 8 years ago

What version of Streams does this release support?

chanskw commented 8 years ago

The proposed deletions are releases, not branches, is that correct ?

chanskw commented 8 years ago

I echo what Dan has proposed, we need to bump the third digit on minor changes and not make up tags like alpha1 going forward. Can you please also indicate in your proposal the version number of this toolkit release ?

Thanks.

ddebrunner commented 8 years ago

I think tags (the qualifier) are valid, and github release does encourage their use for pre-releases, I just think the releases should have been something like

Alex-Cook4 commented 8 years ago

Since this is from the 4.x branch, it is for Streams 4.0 (pre data-governance).

I like the approach of making sure that we up the third digit of the version number for incremental changes. I am fine with giving this release a v4.0.5 tag and upping the version number to 4.0.5.

Is there a good rule of thumb for when to up the third digit of the version number? Would adding a parameter to an operator fit that? Fixing a bug?

ddebrunner commented 8 years ago

See https://github.com/IBMStreams/administration/issues/5

Two releases of a toolkit must not have the same version number.

A bug fix should increase the third digit, new functionality that is backwards compatible should bump the second digit. Incompatible changes (that break existing applications) bump the first.

BTW 4.0.5 was just an example.

chanskw commented 8 years ago

For a 4.0 branch release, please bump version number to v4.0.1 if this release only includes minor bug fixes.

Please delete these alphas: v4.0.0-alpha3 v4.0.0-alpha2 v4.0.0-alpha

Please leave the official v4.0.0 release. This is a stable release and should not get deleted.

Alex-Cook4 commented 8 years ago

I believe the version number should be bumped up to v4.1.0 as this release contains RabbitMQ which was not part of v4.0.0.

+1 to keeping 4.0 branch since it was considered stable.

chanskw commented 8 years ago

ok... +1 to bump to v4.1.0.

Please summarize exactly what we are doing, so we are clear and we can vote on the final proposal.

Alex-Cook4 commented 8 years ago

_Updated Proposal_

Reason: The 4.x branch now has extensively tested versions of RabbitMQ and Kafka.

Title: Messaging Toolkit v4.1.0 Release Tag: v4.1.0

List of Enhancements:

Propose deletion of the following obsolete releases that were done for Message Hub:

Please vote +1 to accept.

chanskw commented 8 years ago

To clarify, we are not deleting the branches / tags.

We are deleting the alpha releases, correct?

Alex-Cook4 commented 8 years ago

Correct. That was a typo, I'll edit to say releases.

chanskw commented 8 years ago

+1 please release.

schubon commented 6 years ago

This issue became irrelevant by history and changed build/release methods discussed elsewhere -> closing.