search

IBMStreams / streamsx.utility

(Incubation) Contains utilities for IBM Streams
Other
1 stars 15 forks source link

Add extended view support to REST API #26

Closed wmarshall484 closed 7 years ago

ddebrunner commented 7 years ago

What's happening to the multi_graph_every functions? Just being deleted or will they be recreated elsewhere?

wmarshall484 commented 7 years ago

I'll recreate them elsewhere, but they definitely don't belong in rest.py. I'm thinking about where to put them. Since these were created with Jupyter visualization in mind, maybe something like streamsx.jupyter or streamsx.jupyter_viz

ddebrunner commented 7 years ago

I guess for backwards compat we just say they have moved, since they probably didn't have widespread usage yet.

wmarshall484 commented 7 years ago

In commit 032694e I separated the threading logic from the view object. Hopefully it should be more clear.

ddebrunner commented 7 years ago

Will the topology api code call into the rest code to obtain the vcap services info, rather than having two copies of the code?

wmarshall484 commented 7 years ago

@ddebrunner, that's a good question. Having the topology api code call the rest code to obtain the vcap services info reduces duplication at the cost of higher coupling.

Right now the topology api only depends on the rest api when views are present. If we make this change, the topology api will depend on the rest api whenever vcap services are supplied.

On the other hand, it is a lot of duplicated code.