IBMa / equal-access

IBM Equal Access Accessibility Checker contains tools to automate accessibility checking from a browser or in a continuous development/build environment

https://www.ibm.com/able/toolkit/tools#develop

Apache License 2.0

630 stars 83 forks source link

[A11y_Bug]: Content not within a landmark element #1930

Closed Mahalakshmivignesh closed 3 weeks ago

Mahalakshmivignesh commented 3 months ago

Project

other

Browser

No response

Operating System

No response

Automated testing tool and ruleset

No response

Assistive technology

No response

Description

Content not within limit error for the pop-menus

Steps to reproduce

https://github.com/IBMa/equal-access/issues/283 - Refer to this issue and the same steps can be used to reproduce. This issue is still not resolved. Any pop window (Ex: actions menu, switcher item list)

MHoov commented 3 months ago

238 was opened Dec 2020

tombrunet commented 3 months ago

@Mahalakshmivignesh The referenced issue was fixed, and the provided examples do not trigger the specified error. Please provide an example that fails with current code.

tombrunet commented 3 months ago

This issue is a little different than the original issue. The original issue was fixed (the owned content is not flagged). However, the focus sentinels are being flagged.

Add role='main' to the storybook root in this example and then open the menu and scan to see the issue: https://react.carbondesignsystem.com/iframe.html?args=&id=components-overflowmenu--default&viewMode=story

The actual menu works fine since it is referenced by the opening button. However, the focus sentinels are flagged.

Unfortunately, I'm not sure if we have a robust way of identifying those as focus sentinels (other than a Carbon-specific implementation).

shunguoy commented 3 months ago

test case: https://react.carbondesignsystem.com/iframe.html?args=&id=components-overflowmenu--default&viewMode=story. Add a role='main' to the storybook root, then click the three-dot button, scan again and the issue appears.

shunguoy commented 3 months ago

Carbon-specific issue related to the sentinel.

Mahalakshmivignesh commented 2 months ago

@shunguoy - Thanks for adding the details. May i know how to get in touch with the team who can fix this sentinel issue? Also, can u help understand the false-positive tag here? will the carbon team be working on fixing this?

shunguoy commented 2 months ago

@Mahalakshmivignesh sorry for the delay on this issue. We are still investigating this to see if it can be detected programmatically. Thanks.

tombrunet commented 1 month ago

@shunguoy Do you think it would work where if the item is both off screen and there is no content between the item and a dialog that we ignore it? It would at least silence the case of sentinels.

philljenkins commented 1 month ago

No change needed to aria_content_in_landmark.html Help

[ ] unless we want to add a note about Why this is important because JAWS users use R key to navigate to next Region/Landmark, and use Insert + F3 command to get a Regions List of the page

Mahalakshmivignesh commented 3 weeks ago

@shunguoy - as per the suggestion given in https://github.com/carbon-design-system/carbon/issues/16946 - i was able to fix this issue by adding data-floating-menu-container="true" to the

tag. Closing this issue.