search

IBMa / equal-access

IBM Equal Access Accessibility Checker contains tools to automate accessibility checking from a browser or in a continuous development/build environment
https://www.ibm.com/able/toolkit/tools#develop
Apache License 2.0
630 stars 83 forks source link

[Feature]: Improve text logic for Sensory words #775

Open mbgower opened 2 years ago

mbgower commented 2 years ago

Project

rule-server

Description

From Slack:

Can someone explain why stop is flagged when used in documentation by the accessibility checker? Also, can we request better intelligence for other words that get flagged. Cases of concern: stop as part of a command (e.g., daylight-stop-minute) top when top-level and is about hierarchy square in square root left and right when discussing sequence and its reversal (e.g., left-to-right and right-to-left) These cases all show that a simple parse leads to more validation by writer BUT with intelligence (parsing with preceding and following "word") can more accurately identify where an accessibility concern might exist.

tombrunet commented 2 years ago

I have to assume the rule is seeing 'top' in s'top'. I agree that's strange. I don't recall anyone commenting on that before, so not sure if something changed with the regex processing. We'll need to revisit this rule.

tombrunet commented 2 years ago

https://codesandbox.io/s/issue-775-eky9qt?file=/index.html @mbgower I agree with the first three. left-to-right still feels questionable to me... it somewhat depends on what they're describing should be left-to-right, does it not?

mbgower commented 2 years ago

Yeah, I agree that that is the least clearly not related to sensory characteristics in these. I'd be inclined to tackle the ones you've IDed and leave left and right in place. I assume you already have some logic to not flag every occurrence of "right"?

shunguoy commented 2 years ago

we need to use regex to find the sensory words. use a list of sensory words to do.

shunguoy commented 2 years ago

look at the exception list of words as well. make sure the help content.

shunguoy commented 2 years ago

we have a rule for this, but need to enhance the rule

MHoov commented 2 months ago

Was this addressed by #1641 @tombrunet