IBT-FMI / gebuilder

Gentoo System and Image Builder
GNU General Public License v3.0
11 stars 0 forks source link

exec.sh-cleanup #36

Open Doeme opened 5 years ago

Doeme commented 5 years ago

There are certain operations inside exec.sh that should go into a script-file, i.e. the ensure_dir for the non-stemgentoo type environments (https://github.com/IBT-FMI/gebuilder/blob/c2fffa772c8223c15ab90181342ed13a297d3fdf/gebuilder/exec.sh#L14)

TheChymera commented 5 years ago

why would this need to be modular?

Doeme commented 5 years ago

Because it is modular? This is a initialize/default specific, so it should reside there. I can't think of a reason why it needs to be done in the exec.sh, except that the .gentoo-path ($1) is only visible by the exec.sh-script, but this would imho be better addressed via a configuration variable.