hub default url to /lab

ICESAT-2HackWeek / jupyterhub-2020

Repository to deploy the JupyterHub for the IceSat-2 2020 Hackweek

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

hub default url to /lab #5

Closed scottyhq closed 4 years ago

scottyhq commented 4 years ago

just ran into this trying new image on the staging hub:

➜  jupyter-image-2020 git:(master) kubectl logs -n hackweek-hub-staging   jupyter-scottyhq  
Traceback (most recent call last):
  File "/srv/conda/envs/notebook/bin/jupyter-labhub", line 6, in <module>
    from jupyterlab.labhubapp import main
ModuleNotFoundError: No module named 'jupyterlab.labhubapp'

fix described in this issue https://github.com/jupyter/docker-stacks/issues/1041

salvis2 commented 4 years ago

weird, that change looks fine.

Seems like the deploy step is run when changes are pushed to a branch, but the image build step is run when pull requests are instantiated. I disabled the image build step in deploy because we aren't doing it, so I should probably just comment out / remove https://github.com/ICESAT-2HackWeek/jupyterhub-2020/blob/staging/.github/workflows/image-build.yaml.