ICHPC / hpc-repo

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Deposit data fails with Safari browser #14

Open hrzepa opened 7 years ago

hrzepa commented 7 years ago

https://data.hpc.imperial.ac.uk/publish/ hangs/waits if used with Safari. The previous diagnosis (disable cross-origin restrictions not selected) was incorrect.

The same pages all work fine with e.g. Opera.

mj-harvey commented 7 years ago

How does it look now?

hrzepa commented 7 years ago

It works if I “disable cross-origin restrictions” on the Safari browser. Eg Opera does not seem to impose this restriction and so it works.

The process using safari with cross-origin restrictions enabled is active (hung) now if you can find it in your logs (it been pending now.

The Javascript error console looks like

[Log] loadModules (application.min.js, line 5) [Log] require /T4Assets/js/require/imperialVideo.jquery.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/unistats.jquery.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/searchGSA.jquery.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/dss-functions.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/reading-list-covers.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require //wwwf.imperial.ac.uk/utils/assets/apps/misc/research_publications/js/script.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/peoplelist.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/seamless.jquery.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/vendor/bootstrap/bootstrap.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/newsevents-page.jquery.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/vendor/bootstrap/bootstrap.min.js,/T4Assets/js/require/vendor/underscore.min.js [object Object] loaded: false (application.min.js, line 5) [Log] require /T4Assets/js/require/vendor/query.min.js [object Object] loaded: false (application.min.js, line 5) [Log] loadHandlers (application.min.js, line 5) [Error] ReferenceError: Can't find variable: doOnLoad onload (publish:89)

On 31 May 2017, at 11:09, M J Harvey notifications@github.com wrote:

How does it look now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

mj-harvey commented 7 years ago

Ok, acquiring a mac to test on...

hrzepa commented 7 years ago

IMore JS errors

[Error] ReferenceError: Can't find variable: dhtmlx Global Code (publish:15) [Log] loadModules (application.min.js, line 5) [Log] require /T4Assets/js/require/imperialVideo.jquery.min.js [object Object] loaded: false (application.min.js, line 5)

On 31 May 2017, at 11:09, M J Harvey notifications@github.com wrote:

How does it look now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

mj-harvey commented 7 years ago

what version of safari do you have? I'm testing with 10.1 (12603.1.30.34) and can't repro

mj-harvey commented 7 years ago

None of those javascript log messages are relevant to this problem, incidentally

mj-harvey commented 7 years ago

Ok - I see:

mj-harvey commented 7 years ago

toggling "disable cross-site restrictions" ddddoesn't seem to change the behaviour I see

mj-harvey commented 7 years ago

If you start a fresh private browsing window, is it ok then?

mj-harvey commented 7 years ago

..and just like that, the problem has resolved itself. Having opened a new safari window, I now can't reproduce it.

hrzepa commented 7 years ago

10.1.2 (12603.3.3)

On 31 May 2017, at 11:42, M J Harvey notifications@github.com wrote:

what version of safari do you have? I'm testing with 10.1 (12603.1.30.34) and can't repro

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

hrzepa commented 7 years ago

OK, I can reproduce this.

Odd.

On 31 May 2017, at 12:00, M J Harvey notifications@github.com wrote:

Ok - I see:

• First click on "Submit" button casuses the button to change colour to light blue and a r POST request to start processing. The webserver sees the request and returns a 401 (not authorized) • A second click on the already activated button sends a second POST request, which this time is correctly authorized with a 200. • Publication then succeeds. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.