design system: navgation breadcrumb

ICIJ / datashare

A self-hosted search engine for documents.

https://datashare.icij.org

GNU Affero General Public License v3.0

584 stars 52 forks source link

Closed pirhoo closed 1 month ago

pirhoo commented 2 months ago

Soliine commented 1 month ago

Well done!

A small detail (not sure it is important but maybe yes, if we search for it one day), the "Mutltiple Addons" here has a small misspelling => it should be "Multiple Addons"
When there are Button or Multiple Addon, the general height of the component is bigger, it could be make the component "jump" when we go from one page without button/addon to a one with button/addon
When we hover a Link which is not the last link of the breadcrumb, the secondary pink bottom border should be visible

pirhoo commented 1 month ago

Got catch for the component height! I fixed it to at least 3rem = 48px which will avoid this effect.

I made the other changes.

Soliine commented 1 month ago

Great!

The only things I see is the configure icon which is pink when hovered while it should be in primary for accessibility reasons

pirhoo commented 1 month ago

This is a "link" button so it behave like a link:

But maybe we should define that those button behave differently?

Soliine commented 1 month ago

Good news: I actually realize we can use this secondary pink for UI component so we can keep the hover state in pink when the link button is an icon:

Soliine commented 1 month ago

The rest is fantastic!