design system: pagination

ICIJ / datashare

A self-hosted search engine for documents.

https://datashare.icij.org

GNU Affero General Public License v3.0

584 stars 52 forks source link

design system: pagination #1434

Closed pirhoo closed 1 month ago

Soliine commented 1 month ago

Looks good!

When we are in row = True and we have number in thousands in the "modelValue", we don't see the comma
When hovering an arrow, I suggest we have it in secondary pink and in bold
I forgot to design it but when hovering the number input, we could have the border in secondary pink

pirhoo commented 1 month ago

Mixing comma/thousands separators is not possible here because the input is of type "number" which has build-in validation in the web browser. I don't advise allowing users to use separator as they can lead to mistakes due to localization difference (US != France != Germany, for instance).