design system: page table

[pirhoo]

• [x] PageTable
• [x] PageTableTh
• [x] PageTableThSort
• [x] PageTableTr
• [x] PageTableTdActions

Preview

[pirhoo]

components are here:

• https://icij.github.io/datashare-client/?path=/docs/components-pagetable-pagetable--docs
• https://icij.github.io/datashare-client/?path=/docs/components-pagetable-pagetableth--docs

[Soliine]

Big big work!

• When I hover the header (PageTableTh) of a small column, I cannot see the sort icon. is it a bug due to the size of the column or because you set them to unsortable?

• Can you right-align any column with numbers (like Page) or is it complicated?

  

• Will we be able to have both Selectmode and the status and privacy columns?

• Should and can we add tooltip on the action icons on the right of the rows?

[pirhoo]

• the narrow columns where you don't see the sort button are just columns where it's not activated
• regarding right-alignment for numbers, here it's just an example of usage of table, we will adjust the formatting later on page where we use tables. I right align the storybook anyway.
• the status display is just an regular column so no problem to have it with the select mode
• the actions buttons here are just example, no the real buttons

[Soliine]

Ok great! Thanks for taking the time to explain