design system: display number human

ICIJ / datashare

A self-hosted search engine for documents.

https://datashare.icij.org

GNU Affero General Public License v3.0

596 stars 53 forks source link

design system: display number human #1500

Closed pirhoo closed 2 months ago

pirhoo commented 3 months ago

In the form 8M, 3K, etc.

pirhoo commented 3 months ago

Component is here: https://icij.github.io/datashare-client/?path=/docs/components-display-displaynumberhuman--docs

Soliine commented 3 months ago

How do we do with translation (to French) for billion (milliard in French) here? We keep the 1B short version or can we translate B into Md or Mrd? 1,000,000 = 1 million (US) = 1 million (FR) 1,000,000,000 = 1 billion (US) = 1 milliard (FR) 1,000,000,000,000 = 1 trillion (US) = 1 billion (FR) I guess it's not that important as these numbers only describe sizes in Datashare, right?

pirhoo commented 3 months ago

We already did the translations 4 years ago, for instance in French:

https://github.com/ICIJ/datashare-client/blob/main/src/lang/fr.json#L856-L868

Soliine commented 3 months ago

Excellent! Thanks for sharing the link