refactor: use enums for repetitive constants - Githubissues

ICIJ / datashare

A self-hosted search engine for documents.

https://datashare.icij.org

GNU Affero General Public License v3.0

598 stars 54 forks source link

refactor: use enums for repetitive constants #1530

Closed caro3801 closed 2 months ago

caro3801 commented 3 months ago

What: use enums for sizes, weights, status, placement, variants, entity categories Why:

provides more semantics for the props (size: button size vs breakpoint size)
provides validators for props
provide reusable args for stories

caro3801 commented 3 months ago

https://github.com/ICIJ/datashare-client/commit/05ce2e45969200fb6feead5fd3cb8c7392db40d6 https://github.com/ICIJ/datashare-client/commit/bdac6ee7660a40ac895ccb9c51588cc46a483684 https://github.com/ICIJ/datashare-client/commit/4fd1f3ce1ee94b76f6fe901051e89d1db50a5905 https://github.com/ICIJ/datashare-client/commit/b4ef9481c7a71922d81e14ee310910da32338406