ICIJ / datashare

A self-hosted search engine for documents.
https://datashare.icij.org
GNU Affero General Public License v3.0
598 stars 54 forks source link

design system: project entries #1542

Closed pirhoo closed 2 months ago

pirhoo commented 2 months ago

A list of projects that can either be listed in a table or in card.

pirhoo commented 2 months ago

The component is here:

Soliine commented 2 months ago

Awesome! It's great to see things taking shape :)

Small feedback: can we add a sorting icon on the "Updated on" column too?

pirhoo commented 2 months ago

I added the sort on the "updated on" column :)

Soliine commented 2 months ago

Great! Well done!

As decided this morning, now we'd like to:

I updated the Figma component accordingly:

Screenshot 2024-09-10 at 15 35 02
Soliine commented 2 months ago

I just saw that you already did the clickable project name, that's awesome!

pirhoo commented 2 months ago

I changed so the buttons of the project row are only visible on hover:

https://icij.github.io/datashare-client/?path=/story/components-project-projectentries-projectentries--default&args=layout:table

I did not hide them in the project card otherwise it would create a lot of blank space.

Soliine commented 2 months ago

Great additions!

The fill of the two buttons is transparent. I designed them with a body-bg (white) background on my side. Do we need this transparency somewhere else? Design:

Screenshot 2024-09-12 at 11 38 13

Storybook:

Screenshot 2024-09-12 at 13 51 22
pirhoo commented 2 months ago

Oups sorry, it's fixed now!

Soliine commented 2 months ago

Awesome!