ICIJ / murmur

ICIJ's Design System for Bootstrap 4 and Vue 2.
https://icij.github.io/murmur/
16 stars 4 forks source link

see this error #3

Closed 8secz-johndpope closed 4 years ago

8secz-johndpope commented 5 years ago

This dependency was not found:

To install it, you can run: npm install --save bootstrap-vue/es/components/modal/modal

Screen Shot 2019-11-14 at 4 45 27 pm

seem like the path has been updated to

npm install --save bootstrap-vue/esm/components/modal/modal

8secz-johndpope commented 5 years ago

there is also some code rot in example. this.$refs fails https://bootstrap-vue.js.org/docs/components/modal/


<div>
  <b-button id="show-btn" @click="$bvModal.show('bv-modal-example')">Open Modal</b-button>

  <b-modal id="bv-modal-example" hide-footer>
    <template v-slot:modal-title>
      Using <code>$bvModal</code> Methods
    </template>
    <div class="d-block text-center">
      <h3>Hello From This Modal!</h3>
    </div>
    <b-button class="mt-3" block @click="$bvModal.hide('bv-modal-example')">Close Me</b-button>
  </b-modal>
</div>
Screen Shot 2019-11-14 at 5 56 37 pm
pirhoo commented 5 years ago

Hi @8secz-johndpope, this dependency is already provided by bootstrap-vue which is present in the package.json. How did you install Murmur ?

pirhoo commented 4 years ago

Closing for inactivity.