search

ICIJ / node-tika

Apache Tika bridge for Node.js. Text and metadata extraction, language detection and more.
MIT License
138 stars 36 forks source link

Inconsistent naming of PDF options #3

Closed rossj closed 9 years ago

rossj commented 9 years ago

The readme file lists PDF options with a pdf prefix, however; the fillPdfOptions() method looks for options without the prefix. I would be happy to make a PR, I just need to know if you want to update the README or the option parser.

Thanks!

mattcg commented 9 years ago

Nicely spotted, thanks for filing. The bug is in the code not the readme because the options are supposed to be prefixed.

On 17 Mar 2015, at 13:39, Ross Johnson notifications@github.com wrote:

The readme file lists PDF options with a pdf prefix, however; the fillPdfOptions() method looks for options without the prefix. I would be happy to make a PR, I just need to know if you want to update the README or the option parser.

Thanks!

— Reply to this email directly or view it on GitHub.