ICIJ / prophecies

An ICIJ app to conduct data validation and cleaning.
https://icij.gitbook.io/prophecies
GNU Affero General Public License v3.0
19 stars 4 forks source link

I filter items by: 'classified value' or 'classification' #10

Closed Soliine closed 3 years ago

Soliine commented 3 years ago
Screenshot 2021-06-23 at 10 45 54
Soliine commented 3 years ago

We replace this filter by 'classified value' or 'classification' = the country (or value) chosen by checkers.

Example: Pierre classified 3 task records in "France". I can filter the task records by "France" thanks to this filter.

It works the same way as the 'Predicted value' filter: Screenshot 2021-08-30 at 12 09 59

madoleary commented 3 years ago

addressed here https://github.com/ICIJ/prophecies/commit/e17843f8b64fddebbb5fa0ac4779294ca92e5ca1

Soliine commented 3 years ago

In my environment, it looks like it works well for the countries I classified but not for the countries that others classified.

Example (others' classification - doesn't filter):

Screenshot 2021-09-01 at 15 41 22 Screenshot 2021-09-01 at 15 41 09

Example (my classification - does filter):

Screenshot 2021-09-01 at 15 43 55

My environment:

pirhoo commented 3 years ago

Yep, that's how I understand it. In guess we have two options:

Soliine commented 3 years ago

We can start with the simplest option, 1, and see if users ask for option 2 later.

In that case, we can rename 'Classified value': 'My classified value', 'Classified value by me'?

pirhoo commented 3 years ago

Since the other filter are also related to the user action, I guess "Classified value" it self-explanatory?

Soliine commented 3 years ago

Not really, the filter 'note' filters not only my notes but also yours. I think it is the same for lock but cannot check.

pirhoo commented 3 years ago

Correct, "lock", "has note" and "has disagreement" are filters at the TaskRecord level (parent of the TaskRecordReview).

pirhoo commented 3 years ago

What about "my suggestion" to keep it short and different from "my classification" ?

Soliine commented 3 years ago

Yes! I also think of "My values" (to mirror "Predicted values")

madoleary commented 3 years ago

'My checked values', maybe? 'My values' is vague, to me. Let me know @pirhoo @Soliine

Soliine commented 3 years ago

'My checked values' sounds great to me

madoleary commented 3 years ago

Cool! Addressed here: https://github.com/ICIJ/prophecies/commit/d557f7c5a7d0b11def2b11eb92fc9c1c0b3e893f