search

ICIJ / prophecies

An ICIJ app to conduct data validation and cleaning.
https://icij.gitbook.io/prophecies
GNU Affero General Public License v3.0
19 stars 4 forks source link

I filter items by: my classifications #11

Closed Soliine closed 3 years ago

Soliine commented 3 years ago
Screenshot 2021-06-23 at 10 49 12
Soliine commented 3 years ago

It seems that if I want to filter Pierre's checked items, I select Assigned to > Pierre and Classification > Correct, Incorrect and Don't know #/task-record-reviews/1?filter%5Btask_record__reviews__checker__in%5D=1&filter%5Bchoice__in%5D=1,2,3 I expect to have Pierre AND (Correct OR Incorrect OR Don't know) as results. But in my environment, I seem to also have task records that were not checked by Pierre, as these ones:

Screenshot 2021-08-31 at 17 08 03

My environment:

Soliine commented 3 years ago

It also looks like the 'Classification' filter works as 'My classification': if I select 'Incorrect', it only shows the records I classified as incorrect, not records classified as incorrect by others. It would explain my comment above. I wonder if it is what we expect. I would expect 'classification' to filter with anyone's classifications, not just mine. But if we don't do that, then I suggest we rename the filter 'Classification' into 'My classification" so it's fully transparent. Let me know what you think!

pirhoo commented 3 years ago

I think it makes more sense that it filters only your classification or we might have task record with different classifications showing in the results. Also "other people classification" is a n+2 relationship so it's a bit heavy.

Soliine commented 3 years ago

Ok I understand! In that case, I suggest we rename the filter with 'My classifications' to be more precise and transparent.