ICMLRecommender / frontend

Frontend project repository
1 stars 3 forks source link

the like button doesn't always turn on. #59

Closed lcharlin closed 7 years ago

lcharlin commented 7 years ago

Description

I don't have a MWE for this one but I've noticed (on three independent occasions) that after browsing papers with the app for a bit one cannot like papers anymore. That is, after clicking on the like button the heart will turn green for a second but will then go back to gray. The bookmark button does not seem to have this problem.

I'm happy to investigate further if needed.

Expected outcome

Actual outcome

Live Demo

Steps to reproduce

Browsers Affected

LazarValkov commented 7 years ago

Could you provide steps to reproduce?

refrigerator commented 7 years ago

hey laurent, could you have the browser console open and see if it says anything when this happens?

the like button has an "optimistic" timeout where the frontend assumes for 2 seconds that the 'like' has successfully gone through in the server + database so that it feels to the user that it's instant. so if it then goes grey it suggests that the server doesn't like it and it hopefully gives us a useful error in the browser console

lcharlin commented 7 years ago

This is on my mobile and I don't think there is a console.

I can try to reproduce from my computer. I'll let you know.

Laurent

On Aug 3, 2017, at 8:24 AM, Taimur Abdaal notifications@github.com wrote:

hey laurent, could you have the browser console open and see if it says anything when this happens?

the like button has an "optimistic" timeout where the frontend assumes for 2 seconds that the 'like' has successfully gone through in the server + database so that it feels to the user that it's instant. so if it then goes grey it suggests that the server doesn't like it and it hopefully gives us a useful error in the browser console

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

lcharlin commented 7 years ago

Here's the desktop output. I confirm that in this case the bookmark button still worked.

Let met know if you need anything else.

screen shot 2017-08-04 at 10 39 27 am
lcharlin commented 7 years ago

One small thing, the problem is the same with un-liking. Screenshot below.

screen shot 2017-08-04 at 10 41 56 am
refrigerator commented 7 years ago

thanks laurent, will investigate further.

refrigerator commented 7 years ago

tried very hard to recreate this but still unable, so not much I can do right now - I suggest we see if any of the beta testers encounter it in the next couple of days and revisit if so