ICOS-Carbon-Portal / data

ICOS Carbon Portal's Data Service
GNU General Public License v3.0
2 stars 3 forks source link

Update csv export title and file name #134

Closed jonathanthiry closed 4 years ago

jonathanthiry commented 4 years ago
mirzov commented 4 years ago

Looks good to me. Using SITES-specific URL for sparqlclient is not completely justified right now, as the page lacks SITES styling, anyway, but since it is now done, I suppose it does not harm. Another thing. Could we, while at it, clean the query to remove empty lines? It is automatically generated, and in many cases has multiple empty lines that make the query appear to be incomplete if the sparqlclient interface (after opening the query).

roger-groth commented 4 years ago

Looks good to me as well. I agree with Oleg, we should clean up the query. I would also like to remove the initial comment line that contains the function name. Perhaps change out the first row in csv result with better headers -> use the headers that are displayed in portal/compact view.

jonathanthiry commented 4 years ago

Sorry I should have written that I was thinking to make the sparql client envri specific to use SITES theme now that we have a link to it from the portal if that's fine with you Oleg.