iconator-monitor should enforce minimum payment amount

ICOnator / ICOnator-backend

ICOnator backend applications and commons

Apache License 2.0

26 stars 1 forks source link

iconator-monitor should enforce minimum payment amount #19

Closed csmuller closed 5 years ago

csmuller commented 6 years ago

The iconator-monitor should compare incoming payments to a minimum payment amount and not allocate tokens for to small payments but rather create a refund entry for them.

csmuller commented 6 years ago

What remains is to discuss if we should inform the investor about the insufficient payment already for pending transactions. In my mind it's much easier when we only check for sufficient payment amount when we process transactions in status building (as it is implemented now). The scenario is:

pending transaction: tell investor that we've seen the payment and are tracking it.
building transaction: check for sufficient amount and create refund entry if it is insufficient. Then inform the investor.

gsmachado commented 5 years ago

@claudemiller I think how it's implemented right now is fine. The only missing part is to inform the investor when an INSUFFICIENT_PAYMENT_AMOUNT refund is performed. But that's what it's being taken care on #20.

Can you check if anything else is missing for this issue/feature and close it? :-)

csmuller commented 5 years ago

@gsmachado A unit test is missing for this feature. But I suggest opening another issue which deals with unit tests for the BaseMonitor and specific Monitor classes, for which more tests can be written. If you agree, then just close this issue and I will open the new one.