ICRAR / EAGLE

Editor for the Astronomical Graph Language Environment
GNU Lesser General Public License v3.0
0 stars 1 forks source link

Eagle 1271 #728

Closed M-Wicenec closed 3 months ago

M-Wicenec commented 3 months ago

Summary by Sourcery

This pull request refactors the port peek functionality to differentiate between input and output peeks, enhances the port dragging logic to handle input and output ports more accurately, and adjusts port position calculations to consider node radius.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request refactors the peek logic in the GraphRenderer and Field classes to distinguish between input and output peeks. It updates various methods and observables to support this change, modifies event handlers and data bindings in the HTML template, and ensures that port peeks are correctly reset and validated during drag operations.

File-Level Changes

Files Changes
src/GraphRenderer.ts
src/Field.ts
Refactored peek logic to distinguish between input and output peeks, updating methods and observables accordingly.
templates/base.html
src/GraphRenderer.ts
Updated data bindings and event handlers to support the new input and output peek logic.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.