ICRAR / EAGLE

Editor for the Astronomical Graph Language Environment
GNU Lesser General Public License v3.0
0 stars 1 forks source link

update from master #732

Closed M-Wicenec closed 3 months ago

M-Wicenec commented 3 months ago

Summary by Sourcery

Update end-to-end tests to fix a logic error in field count verification and correct a typo in a comment. Adjust the z-index in the CSS for better element stacking.

Bug Fixes:

Enhancements:

Chores:

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request contains minor updates and bug fixes across three files: an end-to-end test file for parameter tables and keyboard shortcuts, another for creating and editing palettes, and a CSS file. The changes include improving test assertions, fixing a typo, and adjusting a z-index value.

File-Level Changes

Files Changes
e2e/parameterTableAndKeyboardShortcuts.spec.ts Improved test assertion for field deletion by introducing a new variable to store the count after deletion, making the test more explicit and easier to understand.
e2e/creatingAndEditingPalettes.spec.ts Fixed a typo in a comment, changing 'hellow world' to 'hello world'.
static/base.css Increased the z-index value of a navbar element from 99 to 100, potentially resolving a layering issue in the user interface.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.