ICRAR / EAGLE

Editor for the Astronomical Graph Language Environment
GNU Lesser General Public License v3.0
0 stars 1 forks source link

LIU-406: Update palette URL to point to EAGLE-graph-repo. #741

Closed myxie closed 1 month ago

myxie commented 1 month ago

Summary

As part of ongoing work to improve our synchronisation of graphs between unit-tests, DALiuGE, and EAGLE, we are updating where we store the operational palettes for EAGLE. This PR updates the repository that we access palettes, from the EAGLE_test_repo to the EAGLE-graph-repo.

The reciprocal DALiuGE PR contains the relevant changes to update the automatic workflow; the workflows are already being updated as demonstrated in this commit created by the PR.

Summary by Sourcery

Update the operational palette URLs in the Daliuge class to use the new EAGLE-graph-repo, aligning with ongoing efforts to improve graph synchronization across unit-tests, DALiuGE, and EAGLE.

Enhancements:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request updates the URLs for the EAGLE palette and template files to point to the new EAGLE-graph-repo instead of the EAGLE_test_repo. This change is part of an ongoing effort to improve synchronization of graphs between unit-tests, DALiuGE, and EAGLE.

File-Level Changes

Change Details Files
Update palette and template URLs
  • Change PALETTE_URL to point to EAGLE-graph-repo
  • Change TEMPLATE_URL to point to EAGLE-graph-repo
src/Daliuge.ts

Sequence Diagram

No sequence diagram generated.


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
myxie commented 1 month ago

Hi @james-strauss-uwa, @awicenec: would you mind reviewing these changes? It looks like the unittests are failing but I can't interrogate the errors and am not sure what I should be expecting.

james-strauss-uwa commented 1 month ago

@myxie The build failures are in the Playwright tests, where the test tries to create a component from a palette.

It seems that when you changed the URL for the palettes from EAGLE_test_repo to EAGLE-graph-repo, EAGLE could no longer fetch them at load time.

The palettes don't exist at that new URL.

The palettes are automatically generated by dlg_paletteGen when a commit is made to the DALiuGE repo. So you'll need to commit a change to the DALiuGE repo to have the unit tests push the output of dlg_paletteGen to EAGLE-graph-repo instead of EAGLE_test_repo.

Or, in the short term, you could just manually copy the two palette files from EAGLE_test_repo to EAGLE-graph-repo.

Once the files are in place in EAGLE-graph-repo, then re-running this test should be successful.