search

ICRAR / EAGLE

Editor for the Astronomical Graph Language Environment
GNU Lesser General Public License v3.0
0 stars 1 forks source link

EAGLE-1311: Fix the "[DOM] Password field is not contained in a form" warning in Chrome #745

Closed james-strauss-uwa closed 1 month ago

james-strauss-uwa commented 1 month ago

Added a form around the github and gitlab token entry fields in student mode.

CSS fixes

Summary by Sourcery

Fix the Chrome warning by enclosing the GitHub and GitLab token fields in a form and update CSS to maintain styling consistency.

Bug Fixes:

Enhancements:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request addresses the "[DOM] Password field is not contained in a form" warning in Chrome by adding a form element around the GitHub and GitLab token entry fields in student mode. It also includes some minor CSS adjustments to maintain the existing layout.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a form element around token entry fields
  • Wrapped existing input fields in a
    tag
  • Added autocomplete="off" to password input fields
 templates/modals/settings.html
Applied CSS fixes to maintain layout
  • Added CSS rules to prevent layout changes caused by the new form element
 static/base.css
Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).