Closed james-strauss-uwa closed 1 week ago
This PR removes the unused Eagle.FileType.Daliuge and updates the Field class's type attribute from string to Daliuge.DataType enum. The changes primarily involve removing code related to the Daliuge file type and adjusting file type handling throughout the codebase.
classDiagram
class Eagle {
+ logicalGraph() LogicalGraph
+ saveGraphToDisk(graph: LogicalGraph)
+ showEagleIsLoading()
+ showUserMessage(title: string, message: string)
+ determineEagleVersion(dataObject: any) string
}
note for Eagle "Removed handling for Eagle.FileType.Daliuge."
Change | Details | Files |
---|---|---|
Removed Eagle.FileType.Daliuge enum value and related code |
|
src/Eagle.ts src/Utils.ts src/Repositories.ts src/Modals.ts src/RepositoryFile.ts |
Changed Field class type attribute from string to Daliuge.DataType |
|
src/Field.ts src/Utils.ts src/Eagle.ts |
This filetype was added back when we were considering having a completely new file type to include the GraphConfigs. A "daliuge" file. In the end, we just placed the graph configs inside the LogicalGraph, removing the need for a new file type.
Also, changed the "type" attribute on the Field class from a string to a Daliuge.DataType. This is a little unusual, since the "type" for a field can be anything. "MeasurementSet" or "Object.Observation" etc. It doesn't just have to be a known value within the Enum. But typescript allows you to give arbitrary values to Enums, so it is not an issue in practice. And it does have some advantages in code completion/typing.
Summary by Sourcery
Enhancements: