ICRAR / EAGLE

Editor for the Astronomical Graph Language Environment
GNU Lesser General Public License v3.0
0 stars 1 forks source link

EAGLE-1350: Error "Active Graph Config Id (null) does not match a known graph config" should not be an error #776

Open james-strauss-uwa opened 7 hours ago

james-strauss-uwa commented 7 hours ago

Fixed bug where activeGraphConfigId is null, but was written as 'null' (a string) into the output JSON

Summary by Sourcery

Bug Fixes:

sourcery-ai[bot] commented 7 hours ago

Reviewer's Guide by Sourcery

The PR fixes a JSON serialization bug where a null activeGraphConfigId was being incorrectly written as the string "null" instead of the JSON null value. The implementation adds a conditional check to handle null values separately from string values during JSON generation.

Class diagram for LogicalGraph JSON serialization update

classDiagram
    class LogicalGraph {
        +String modelData
        +String activeGraphConfigId
        +String toJSON()
    }
    note for LogicalGraph "Updated to handle null activeGraphConfigId correctly in JSON output"

File-Level Changes

Change Details Files
Modified JSON serialization to properly handle null activeGraphConfigId
  • Replaced direct string concatenation with conditional logic
  • Added separate handling for null values to output 'null' instead of '"null"'
  • Maintained existing string handling for non-null values
src/LogicalGraph.ts

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).