ICRAR / crc32c

A python package implementing the crc32c algorithm in hardware and software
GNU Lesser General Public License v2.1
41 stars 25 forks source link

github actions, fixes #15 #16

Closed christopher-hesse closed 4 years ago

christopher-hesse commented 4 years ago

Travis seems to be barely maintained at this point and their windows support has a few issues. Github actions is a bit weird but at least it's popular and maintained and supports all the platforms with no additional setup.

christopher-hesse commented 4 years ago

Here's the link to the output on my fork: https://github.com/christopher-hesse/crc32c/actions/runs/148904345

When it's complete there's an artifact link that can be downloaded containing all the wheels. This script also has some support for uploading to pypi, but I didn't try it out.

I also have not tried the wheels, but they seem to have passed the tests.

rtobar commented 4 years ago

Neat, specially the fact that there's a single artifact zipfile containing all one would want. I'll have a closer look at the changes now, thanks a lot!

rtobar commented 4 years ago

Just tried two of the manylinux1 wheels (2.7-mu and 3.8) and both worked fine. I also tried the source distribution, and while it failed to compile it was only because of an issue that was uncovered by your work (not introduced by it), and by the fact that I've been building source distributions locally until now. The changes look great, so thanks again for keeping them so neat and well commented, it was a breeze to try out.

I'm now giving this a full try against test.pypi.org. After confirming all is working fine I'll merge this to the master branch, cleanup a bit (DOS line endings, adjust comments, update README badges, remove AppVeyor/Travis checks from GitHub, etc.), fix the source distribution generation, and produce a new 2.0.1 release.

christopher-hesse commented 4 years ago

I just copied and pasted the cibuildwheel example: https://github.com/joerick/cibuildwheel/blob/master/examples/github-deploy.yml

rtobar commented 4 years ago

Even easier! I might port in the future some other projects to use this, it looks quite neat.